log instead of throwing errors

Author: leolambo

packages/bitcore-wallet-client/src/lib/verifier.ts

@@ -182,8 +182,10 @@ export class Verifier {
         return true;
     });
 
-    if (!creatorKeys)
-      throw new Error('Missing creator key')
+    if (!creatorKeys) {
+      log.error('Missing creator key')
+      return false;
+    }
 
     var creatorSigningPubKey;
 
@@ -196,15 +198,17 @@ export class Verifier {
           txp.proposalSignaturePubKeySig,
           creatorKeys.xPubKey
         )
-      )
-        throw new Error('Invalid self-signed proposal signature')
-
+      ) {
+        log.error('Invalid self-signed proposal signature')
+        return false;
+      }
       creatorSigningPubKey = txp.proposalSignaturePubKey;
     } else {
       creatorSigningPubKey = creatorKeys.requestPubKey;
     }
-    if (!creatorSigningPubKey)
-      throw new Error('Missing creator signing key');
+    if (!creatorSigningPubKey){
+      log.error('Missing creator signing key');
+    }
 
     var hash;
     if (parseInt(txp.version) >= 3) {
@@ -222,11 +226,15 @@ export class Verifier {
     );
 
     const verified = Utils.verifyMessage(hash, txp.proposalSignature, creatorSigningPubKey);
-    if (!verified && !txp.prePublishRaw)
-        throw new Error('Invalid proposal signature');
-    
-    if (!verified && txp.prePublishRaw && !Utils.verifyMessage(txp.prePublishRaw, txp.proposalSignature, creatorSigningPubKey))
-        throw new Error('Invalid refreshed proposal signature');
+    if (!verified && !txp.prePublishRaw) {
+      log.error('Invalid proposal signature');
+      return false;
+    }
+        
+    if (!verified && txp.prePublishRaw && !Utils.verifyMessage(txp.prePublishRaw, txp.proposalSignature, creatorSigningPubKey)) {
+      log.error('Invalid proposal signature');'Invalid refreshed proposal signature');
+      return false 
+    }
 
     if (Constants.UTXO_CHAINS.includes(chain)) {
       if (!this.checkAddress(credentials, txp.changeAddress)) {
@@ -289,9 +297,15 @@ export class Verifier {
   static checkTxProposal(credentials, txp, opts) {
     opts = opts || {};
 
-    if (!this.checkTxProposalSignature(credentials, txp)) return false;
+    if (!this.checkTxProposalSignature(credentials, txp)) {
+      log.error('Transaction proposal signature check failed');
+      return false;
+    }
 
-    if (opts.paypro && !this.checkPaypro(txp, opts.paypro)) return false;
+    if (opts.paypro && !this.checkPaypro(txp, opts.paypro)) {
+      log.error('Transaction proposal paypro check failed');
+      return false;
+    }
 
     return true;
   }