Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All Button is not working properly [BUG] #465

Closed
siva04 opened this issue May 30, 2024 · 5 comments · Fixed by #524
Closed

Select All Button is not working properly [BUG] #465

siva04 opened this issue May 30, 2024 · 5 comments · Fixed by #524
Labels
bug Something isn't working

Comments

@siva04
Copy link

siva04 commented May 30, 2024

Select all button not working properly in multiple select enabled

image

while select all is selected and selected values are reset the select all button is not deselected

image

while select all is selected and 1 option deselected the select all button is not deselected

@siva04 siva04 added the bug Something isn't working label May 30, 2024
@macjohnny
Copy link
Member

@siva04 the state of the select all checkbox is controlled via

@Input() toggleAllCheckboxChecked = false;
/** select all checkbox indeterminate state */
@Input() toggleAllCheckboxIndeterminate = false;

do you want to fix this in the demo?

@swierzbicki
Copy link
Contributor

  1. @macjohnny i can take this bug. Is it only on demo page or somewhere else?
  2. Basically is there somekind of discord or some channel when we can get in touch? I would like to ask about contributions. What can i take? Are there any specific rules etc.? Because i would like to take something more serious. But of course... baby steps. Don't want to take the biggest feature. Becasue i need to do some warmups to be more familiar with repo code :)

@macjohnny
Copy link
Member

@swierzbicki thanks for offering help, thats much appreciated.

  1. i think the problem is on the demo page, since the select-all control in ngx-mat-select-search does not have any logic
  2. you could connect with me on linkedin or via the email on bithost.ch/team

@swierzbicki
Copy link
Contributor

@macjohnny
if i understand correctly. this is the issue:

Image

1. When i "select all" and unselect specific option:

  • current behaviour: "select all" is checked
  • expected behaviour: "select all" is unchecked

2. When i select all option one by one manually

  • current behavior: "select all" is unchecked
  • expected behavior: 'select all" is checked

@swierzbicki
Copy link
Contributor

Ok. I think i fixed this.

Image

swierzbicki added a commit to swierzbicki/ngx-mat-select-search that referenced this issue Feb 9, 2025
swierzbicki added a commit to swierzbicki/ngx-mat-select-search that referenced this issue Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants