-
Notifications
You must be signed in to change notification settings - Fork 390
Move TxTemplate
to bdk_testenv
and make it better
#1936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@evanlinjin I would like to work on this. |
Can i work on this? Is it closed? I would like to learn on how to contribute to this project. |
Hey, @notmandatory, can I work on this issue? Since the PR doesn’t seem to be active, I believe the issue is still open for contributions. |
@notmandatory: This issue focuses on the |
Oops thanks @ValuedMammal for moving this back to |
Context
The
TxTemplate
stuff currently resides incrates/chain/tests/common/mod.rs
, making it only accessible forbdk_chain
tests residing in thetests
dir.However, building a
TxGraph
fromTxTemplate
s are useful elsewhere (such as for benchmarks as I've discovered while working on #1670 - more on this later).Proposal
TxTemplate
types and logic tobdk_testenv
.Cow<'static, B>
for struct fields andinit_graph
inputs. This allows us to be more flexible when creating templates (they can be owned and returned by methods and manipulated later on).O(n)
canonicalization algorithm #1670 usingTxTemplate
.3.
easier.Dependencies
This should be done after #1670 is merged to avoid merge conflicts.
The text was updated successfully, but these errors were encountered: