Merge #1704: cmake: Make secp256k1_objs inherit interface defines from secp256k1

real-or-random · real-or-random · commit 73a695958a0b · 2025-07-21T13:37:30.000+02:00
bf08222 cmake: Make `secp256k1_objs` inherit interface defines from `secp256k1` (Hennadii Stepanov) Pull request description: This PR effectively adds `-DSECP256K1_STATIC` to usage requirements of `secp256k1_objs` on Windows, preventing LNK4217 linker warnings. I overlooked this issue while reviewing #1678. ACKs for top commit: real-or-random: utACK bf08222 Tree-SHA512: d31e963378b795fd2be88f26574561f1e16b4c2fe10f348f6bfcf1bcc7e68da81ff93475548e9513514ded8eef5a0bd5e2eac2f4a9c5b879e0ab171e49dfcad5
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -86,7 +86,8 @@ target_include_directories(secp256k1 INTERFACE
   $<BUILD_INTERFACE:$<$<NOT:$<BOOL:${PROJECT_IS_TOP_LEVEL}>>:${PROJECT_SOURCE_DIR}/include>>
 )
 set_target_properties(secp256k1_objs PROPERTIES
-    INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"
+  INTERFACE_COMPILE_DEFINITIONS "$<TARGET_PROPERTY:secp256k1,INTERFACE_COMPILE_DEFINITIONS>"
+  INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"
 )
 
 # This emulates Libtool to make sure Libtool and CMake agree on the ABI version,

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ target_include_directories(secp256k1 INTERFACE`
`86`	`86`	`$<BUILD_INTERFACE:$<$<NOT:$<BOOL:${PROJECT_IS_TOP_LEVEL}>>:${PROJECT_SOURCE_DIR}/include>>`
`87`	`87`	`)`
`88`	`88`	`set_target_properties(secp256k1_objs PROPERTIES`
`89`		`- INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"`
	`89`	`+ INTERFACE_COMPILE_DEFINITIONS "$<TARGET_PROPERTY:secp256k1,INTERFACE_COMPILE_DEFINITIONS>"`
	`90`	`+ INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"`
`90`	`91`	`)`
`91`	`92`
`92`	`93`	`# This emulates Libtool to make sure Libtool and CMake agree on the ABI version,`