qt: don't pass BitcoinGUI to bringToFront()

diegoviola · diegoviola · commit 6f71ab203ae4 · 2025-10-18T14:30:35.000-03:00
The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker. Fixes #903 and bitcoin/bitcoin#33432.
diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp
@@ -1510,8 +1510,6 @@ void BitcoinGUI::showNormalIfMinimized(bool fToggleHidden)
 
     if (!isHidden() && !isMinimized() && !GUIUtil::isObscured(this) && fToggleHidden) {
         hide();
-    } else {
-        GUIUtil::bringToFront(this);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1510,8 +1510,6 @@ void BitcoinGUI::showNormalIfMinimized(bool fToggleHidden)`
`1510`	`1510`
`1511`	`1511`	`if (!isHidden() && !isMinimized() && !GUIUtil::isObscured(this) && fToggleHidden) {`
`1512`	`1512`	`hide();`
`1513`		`- } else {`
`1514`		`- GUIUtil::bringToFront(this);`
`1515`	`1513`	`}`
`1516`	`1514`	`}`
`1517`	`1515`