Commit f8e994d
committed
Merge #487: Use handlers with explicit parameters in main.qml and DesktopWallets.qml
99d5da8 Update signal handlers in DesktopWallets.qml to have explicit parameters (johnny9)
da6bc7c Update signal handlers in main.qml to have explicit parameters (johnny9)
Pull request description:
Signals with parameters should have handlers that explicitly define the arguments. Without this, Qt will throw a warning in the log stating that injection or parameters is deprecated.
fixes #481
ACKs for top commit:
hebasto:
ACK 99d5da8, tested on Ubuntu 24.04.
Tree-SHA512: 510ab99aeaa8418cc28886452bed28d7cc8c6697286e89d19e4a5cc593dda5f3d07d1e7ca5856be60dc8c6efb50d8e1626ca1a111457dbede6267bf6d1bfe62c2 files changed
+5
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
145 | 147 | | |
146 | 148 | | |
147 | 149 | | |
| |||
0 commit comments