Skip to content

Commit a851e49

Browse files
authored
Better consistency naming of headmodes (#653)
2 parents 007f923 + bd8f3e3 commit a851e49

6 files changed

Lines changed: 261 additions & 251 deletions

File tree

bitbots_behavior/bitbots_blackboard/bitbots_blackboard/capsules/misc_capsule.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
from bitbots_msgs.msg import Audio, HeadMode, RobotControlState
99

1010
THeadMode: TypeAlias = Literal[ # type: ignore[valid-type]
11-
HeadMode.BALL_MODE,
12-
HeadMode.FIELD_FEATURES,
11+
HeadMode.SEARCH_BALL,
12+
HeadMode.SEARCH_FIELD_FEATURES,
1313
HeadMode.LOOK_FORWARD,
1414
HeadMode.DONT_MOVE,
15-
HeadMode.BALL_MODE_PENALTY,
16-
HeadMode.LOOK_FRONT,
15+
HeadMode.SEARCH_BALL_PENALTY,
16+
HeadMode.SEARCH_FRONT,
1717
]
1818

1919

bitbots_behavior/bitbots_body_behavior/bitbots_body_behavior/behavior_dsd/actions/head_modes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,15 @@ class SearchBall(AbstractHeadModeElement):
4545
"""Look for ball"""
4646

4747
def perform(self):
48-
self.blackboard.misc.set_head_duty(HeadMode.BALL_MODE)
48+
self.blackboard.misc.set_head_duty(HeadMode.SEARCH_BALL)
4949
return self.pop()
5050

5151

5252
class LookAtFieldFeatures(AbstractHeadModeElement):
5353
"""Look generally for all features on the field (ball, goals, corners, center point)"""
5454

5555
def perform(self):
56-
self.blackboard.misc.set_head_duty(HeadMode.FIELD_FEATURES)
56+
self.blackboard.misc.set_head_duty(HeadMode.SEARCH_FIELD_FEATURES)
5757
return self.pop()
5858

5959

@@ -77,13 +77,13 @@ class LookAtBallPenalty(AbstractHeadModeElement):
7777
"""Ball Mode adapted for Penalty Kick"""
7878

7979
def perform(self):
80-
self.blackboard.misc.set_head_duty(HeadMode.BALL_MODE_PENALTY)
80+
self.blackboard.misc.set_head_duty(HeadMode.SEARCH_BALL_PENALTY)
8181
return self.pop()
8282

8383

8484
class LookAtFront(AbstractHeadModeElement):
8585
"""Search in front of the robot"""
8686

8787
def perform(self):
88-
self.blackboard.misc.set_head_duty(HeadMode.LOOK_FRONT)
88+
self.blackboard.misc.set_head_duty(HeadMode.SEARCH_FRONT)
8989
return self.pop()

bitbots_misc/bitbots_teleop/scripts/teleop_keyboard.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,12 @@ def loop(self):
222222
self.head_pub.publish(self.head_msg)
223223
elif key == "0":
224224
# Search for Ball and track it if found
225-
self.head_mode_msg.head_mode = HeadMode.BALL_MODE
226-
assert int(key) == HeadMode.BALL_MODE
225+
self.head_mode_msg.head_mode = HeadMode.SEARCH_BALL
226+
assert int(key) == HeadMode.SEARCH_BALL
227227
elif key == "1":
228228
# Look generally for all features on the field (ball, goals, corners, center point)
229-
self.head_mode_msg.head_mode = HeadMode.FIELD_FEATURES
230-
assert int(key) == HeadMode.FIELD_FEATURES
229+
self.head_mode_msg.head_mode = HeadMode.SEARCH_FIELD_FEATURES
230+
assert int(key) == HeadMode.SEARCH_FIELD_FEATURES
231231
elif key == "2":
232232
# Simply look directly forward
233233
self.head_mode_msg.head_mode = HeadMode.LOOK_FORWARD
@@ -238,12 +238,12 @@ def loop(self):
238238
assert int(key) == HeadMode.DONT_MOVE
239239
elif key == "4":
240240
# Ball Mode adapted for Penalty Kick
241-
self.head_mode_msg.head_mode = HeadMode.BALL_MODE_PENALTY
242-
assert int(key) == HeadMode.BALL_MODE_PENALTY
241+
self.head_mode_msg.head_mode = HeadMode.SEARCH_BALL_PENALTY
242+
assert int(key) == HeadMode.SEARCH_BALL_PENALTY
243243
elif key == "5":
244244
# Do a pattern which only looks in front of the robot
245-
self.head_mode_msg.head_mode = HeadMode.LOOK_FRONT
246-
assert int(key) == HeadMode.LOOK_FRONT
245+
self.head_mode_msg.head_mode = HeadMode.SEARCH_FRONT
246+
assert int(key) == HeadMode.SEARCH_FRONT
247247
elif key == "y":
248248
# kick left forward
249249
pass

0 commit comments

Comments
 (0)