Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: update pre-commit to ruff #50

Open
evamaxfield opened this issue Jul 5, 2024 · 1 comment
Open

Admin: update pre-commit to ruff #50

evamaxfield opened this issue Jul 5, 2024 · 1 comment
Labels
admin high level changes about the package or documentation enhancement New feature or request

Comments

@evamaxfield
Copy link
Contributor

From: #48 (comment)

Just as a general note, this is all fine but ruff does all of these in one except for black. My pre-commit configs are now: black, ruff, mypy

In short, ruff is a new-ish tool for linting, formating, isorting, etc. It pull in all of the standards from existing systems into a single tool and is much faster at processing a whole repo's worth of changes.

See here for an example of my current pre-commit config: https://github.com/evamaxfield/rs-graph/blob/main/.pre-commit-config.yaml

Ignoring the notebooks section and the mypy extended types installs I generally think this is the minimum that pre-commit needs to be set up with now that Ruff does so much of the work.

@evamaxfield evamaxfield added enhancement New feature or request admin high level changes about the package or documentation labels Jul 5, 2024
@psobolewskiPhD
Copy link

In napari land we've started using the ruff formater instead of black too:
https://docs.astral.sh/ruff/formatter/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin high level changes about the package or documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants