feature/parameterized-ome-tiff-writer-compression #88
Conversation
evamaxfield
requested review from
toloudis,
hughes036,
aswallace,
SeanLeRoy,
yrkim98 and
BrianWhitneyAI
|
It says it resolves #36 but I think that one mentions both tiff and zarr. We need to at least have another open issue for zarr. |
There was a problem hiding this comment.
@toloudis this PR has been updated to allow for all tifffile write kwargs to be passed. This should resolve the lack of compression args and generally just future proofing us a bit in the case people want to use other parameters.
Docstring includes custom compression example
|
Quick note: seems like |
|
I'm generally in favor of using current things but we might have to put a min value on our tifffile version? |
|
Ping on this. I don't think we need to change our minimum tifffile version for a bit. Good to merge though? @toloudis @SeanLeRoy @BrianWhitneyAI |
I thought you were going to do something to use the more current (post-2022) enum |
…ME TIFF Writer
Link to Relevant Issue
This pull request:
Description of Changes
This moves the hard coded compression setting in OmeTiffWriter to a parameter.
My only general discussion point before this gets merged is perhaps maybe we should just open up all tifffile kwargs like how we do with
fs_kwargs?