DEP: remove external samplers#1090
Conversation
|
I've triggered a workflow to rebuild the containers: https://github.com/bilby-dev/bilby/actions/runs/25503395807 |
ColmTalbot
left a comment
There was a problem hiding this comment.
Looks like some change are still needed in https://github.com/bilby-dev/bilby/blob/remove-external-samplers/test/core/sampler/base_sampler_test.py, you might also pin arviz<1 until we support the new version.
|
Actually, it looks like I fixed this in https://github.com/bilby-dev/bilby/pull/1067/changes, so maybe a rebase will just fix the CI issues (other than the sampler side). |
921b30e to
a0c10c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 66.20% 70.61% +4.40%
==========================================
Files 89 77 -12
Lines 17079 15156 -1923
Branches 2647 2360 -287
==========================================
- Hits 11308 10702 -606
+ Misses 5028 3749 -1279
+ Partials 743 705 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ColmTalbot any idea where this dynesty failure is coming from? |
|
No, but it looks like there was a new commit a few days ago. |
|
I agree the dynesty test probably shouldn't be a required test (I think you might have changed that already?). |
adivijaykumar
left a comment
There was a problem hiding this comment.
Looks good to me, modulo the CI failure.
Re-add proposal.py
a0c10c9 to
bbba59e
Compare
This PR supersedes #1046.
It is made from the main repo so the containers can be rebuilt.
See the original PR for previous discussions.