DEP: remove ability to use parameters as state#1050
Merged
Conversation
ColmTalbot
force-pushed
the
no-parameters-as-state
branch
from
dc31a80 to
04b32ef
Compare
mj-will
reviewed
Apr 22, 2026
Collaborator
mj-will
left a comment
mj-will
left a comment
There was a problem hiding this comment.
I couple of minor comments mostly about doc-strings.
asb5468
reviewed
Apr 30, 2026
asb5468
reviewed
Apr 30, 2026
asb5468
reviewed
Apr 30, 2026
asb5468
approved these changes
May 14, 2026
mj-will
approved these changes
May 14, 2026
Collaborator
mj-will
left a comment
mj-will
left a comment
There was a problem hiding this comment.
Thanks for making those changes Colm, LGTM now!
ColmTalbot
force-pushed
the
no-parameters-as-state
branch
from
5021c97 to
0770339
Compare
Collaborator
Author
|
I had to manually rebase after some samplers were removed so this needs a reapproval. |
mj-will
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likelihoods (and the waveform generator) will no longer allow a
.parametersattribute to be used.