Skip to content

Improve facet limitation#41

Merged
jajm merged 1 commit intomasterfrom
improve-facet-limitation
Apr 10, 2026
Merged

Improve facet limitation#41
jajm merged 1 commit intomasterfrom
improve-facet-limitation

Conversation

@ThibaudGLT
Copy link
Copy Markdown
Contributor

  • Add a collapse button with specific label setting
  • Fix behavior when search is updated with new selected facet
  • Add reset button
  • Change filter button icon

@ThibaudGLT ThibaudGLT requested a review from jajm March 18, 2026 15:27
- Split the single expand button into two distinct buttons (expand /
  collapse), each with a chevron icon (fas fa-chevron-down /
  fas fa-chevron-up), shown or hidden via CSS classes.
- Add a new admin setting `facet_limit_collapse_label` to configure
  the label of the collapse button (like the existing
  `facet_limit_expand_label`)
- Add a "Reset all filters" button (#reset-facets) in faceted filtering
  mode that clears all active facet parameters from the URL
- Fix checkbox value attribute in facet-link.phtml: was incorrectly set
  to $name instead of $value
- Fix submitFacets(): also delete the page parameter when applying
  facets, and refactor facet-name detection into reusable helper
  functions (getVisibleFacetNames, isVisibleFacetParam)
- Minor code style harmonisation (single quotes to double quotes,
  spacing)
@ThibaudGLT ThibaudGLT force-pushed the improve-facet-limitation branch from e85e6d5 to 7897171 Compare April 10, 2026 09:02
@jajm jajm merged commit c8daa83 into master Apr 10, 2026
@jajm jajm deleted the improve-facet-limitation branch April 10, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants