Bug 1637869 - P7. Call DisconnectChildListeners when an error occurs. r=mattwoodrow

Jean-Yves Avenard · bgrins · commit d31ed90d9c45 · 2020-05-29T10:31:03.000-07:00
This will allow the DocumentChannel to be removed from the loading group and the docshell to stop waiting for for the ParentProcessDocumentChannel to do something. Depends on D77201 Differential Revision: https://phabricator.services.mozilla.com/D77202
diff --git a/netwerk/ipc/DocumentLoadListener.cpp b/netwerk/ipc/DocumentLoadListener.cpp
@@ -805,6 +805,7 @@ void DocumentLoadListener::FinishReplacementChannelSetup(nsresult aResult) {
     if (NS_FAILED(aResult)) {
       mChannel->Cancel(aResult);
       mChannel->Resume();
+      DisconnectChildListeners(aResult, aResult);
       return;
     }
     ApplyPendingFunctions(mChannel);

Original file line number	Diff line number	Diff line change
`@@ -805,6 +805,7 @@ void DocumentLoadListener::FinishReplacementChannelSetup(nsresult aResult) {`
`805`	`805`	`if (NS_FAILED(aResult)) {`
`806`	`806`	`mChannel->Cancel(aResult);`
`807`	`807`	`mChannel->Resume();`
	`808`	`+ DisconnectChildListeners(aResult, aResult);`
`808`	`809`	`return;`
`809`	`810`	`}`
`810`	`811`	`ApplyPendingFunctions(mChannel);`