Rename with_child into spawn_child

Author: Sigma-dev

crates/bevy_dev_tools/src/fps_overlay.rs

@@ -175,7 +175,7 @@ fn setup(
                 FpsText,
                 Pickable::IGNORE,
             ))
-            .with_child((TextSpan::default(), overlay_config.text_config.clone()));
+            .spawn_child((TextSpan::default(), overlay_config.text_config.clone()));
 
             let font_size = overlay_config.text_config.font_size;
             p.spawn((

crates/bevy_ecs/src/hierarchy.rs

@@ -372,7 +372,17 @@ impl<'w> EntityWorldMut<'w> {
     /// For efficient spawning of multiple children, use [`with_children`].
     ///
     /// [`with_children`]: EntityWorldMut::with_children
+    #[deprecated = "Use spawn_child instead"]
     pub fn with_child(&mut self, bundle: impl Bundle) -> &mut Self {
+        self.spawn_child(bundle)
+    }
+
+    /// Spawns the passed bundle and adds it to this entity as a child.
+    ///
+    /// For efficient spawning of multiple children, use [`with_children`].
+    ///
+    /// [`with_children`]: EntityWorldMut::with_children
+    pub fn spawn_child(&mut self, bundle: impl Bundle) -> &mut Self {
         let parent = self.id();
         self.world_scope(|world| {
             world.spawn((bundle, ChildOf(parent)));
@@ -484,7 +494,17 @@ impl<'a> EntityCommands<'a> {
     /// For efficient spawning of multiple children, use [`with_children`].
     ///
     /// [`with_children`]: EntityCommands::with_children
+    #[deprecated = "Use spawn_child instead"]
     pub fn with_child(&mut self, bundle: impl Bundle) -> &mut Self {
+        self.spawn_child(bundle)
+    }
+
+    /// Spawns the passed bundle and adds it to this entity as a child.
+    ///
+    /// For efficient spawning of multiple children, use [`with_children`].
+    ///
+    /// [`with_children`]: EntityCommands::with_children
+    pub fn spawn_child(&mut self, bundle: impl Bundle) -> &mut Self {
         self.with_related::<ChildOf>(bundle);
         self
     }

crates/bevy_ui/src/experimental/ghost_hierarchy.rs

@@ -217,16 +217,16 @@ mod tests {
                 parent.spawn((A(2), Node::default()));
                 parent
                     .spawn((A(3), GhostNode))
-                    .with_child((A(4), Node::default()));
+                    .spawn_child((A(4), Node::default()));
             });
 
         // Ghost root
         world.spawn((A(5), GhostNode)).with_children(|parent| {
             parent.spawn((A(6), Node::default()));
             parent
                 .spawn((A(7), GhostNode))
-                .with_child((A(8), Node::default()))
-                .with_child(A(9));
+                .spawn_child((A(8), Node::default()))
+                .spawn_child(A(9));
         });
 
         let mut system_state = SystemState::<(UiRootNodes, Query<&A>)>::new(world);

crates/bevy_ui/src/layout/mod.rs

@@ -685,7 +685,7 @@ mod tests {
         let world = app.world_mut();
 
         // spawn an invalid UI root node
-        let root_node = world.spawn(()).with_child(Node::default()).id();
+        let root_node = world.spawn(()).spawn_child(Node::default()).id();
 
         app.update();
         let world = app.world_mut();

examples/3d/spherical_area_lights.rs

@@ -57,7 +57,7 @@ fn setup(
                 Transform::from_xyz(position_range.start + percent * pos_len, 0.3, 0.0)
                     .with_scale(Vec3::splat(radius)),
             ))
-            .with_child(PointLight {
+            .spawn_child(PointLight {
                 radius,
                 color: Color::srgb(0.2, 0.2, 1.0),
                 ..default()

examples/camera/first_person_view_model.rs

@@ -195,7 +195,7 @@ fn spawn_text(mut commands: Commands) {
             left: px(12),
             ..default()
         })
-        .with_child(Text::new(concat!(
+        .spawn_child(Text::new(concat!(
             "Move the camera with your mouse.\n",
             "Press arrow up to decrease the FOV of the world model.\n",
             "Press arrow down to increase the FOV of the world model."

examples/ecs/error_handling.rs

@@ -110,7 +110,7 @@ fn setup(
 
     // Add sample points as children of the sphere:
     for point in distribution.sample_iter(&mut seeded_rng).take(10000) {
-        sphere.with_child((
+        sphere.spawn_child((
             Mesh3d(point_mesh.clone()),
             MeshMaterial3d(point_material.clone()),
             Transform::from_translation(point),

examples/ecs/iter_combinations.rs

@@ -107,7 +107,7 @@ fn generate_bodies(
             Transform::from_scale(Vec3::splat(star_radius)),
             Star,
         ))
-        .with_child(PointLight {
+        .spawn_child(PointLight {
             color: Color::WHITE,
             range: 100.0,
             radius: star_radius,

examples/games/contributors.rs

@@ -156,7 +156,7 @@ fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
                 ..default()
             },
         ))
-        .with_child((
+        .spawn_child((
             TextSpan::default(),
             TextFont {
                 font_size: 30.,

examples/games/loading_screen.rs

@@ -90,7 +90,7 @@ fn setup(mut commands: Commands) {
             },
             BackgroundColor(Color::NONE),
         ))
-        .with_child((Text::new("Press 1 or 2 to load a new scene."), text_style));
+        .spawn_child((Text::new("Press 1 or 2 to load a new scene."), text_style));
 }
 
 // Selects the level you want to load.
@@ -256,7 +256,7 @@ fn load_loading_screen(mut commands: Commands) {
             BackgroundColor(Color::BLACK),
             LoadingScreen,
         ))
-        .with_child((Text::new("Loading..."), text_style.clone()));
+        .spawn_child((Text::new("Loading..."), text_style.clone()));
 }
 
 // Determines when to show the loading screen