Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual theme selection #191

Open
petertakacs opened this issue Jan 10, 2022 · 6 comments
Open

Allow manual theme selection #191

petertakacs opened this issue Jan 10, 2022 · 6 comments

Comments

@petertakacs
Copy link

I'm using the extension with enterprise github with an older version that does not have Dark mode yet, however my macOS uses dark mode which results in a light github theme with a dark box with dark fonts as well.
image

@JoepKockelkorn
Copy link

I have the same 'problem'

@matheuskiser
Copy link

Having the same issue here. In the meantime, I'm using Dark Reader Chrome extension to switch the pages to dark mode and that slightly fixes the issue of not seeing the file structure.

@berzniz
Copy link
Owner

berzniz commented Jan 11, 2022

Thanks for reporting. What's the best way to reproduce this? Are you on a Mac/PC? What are your system dark mode preferences? What are your GitHub theme preferences?

@petertakacs
Copy link
Author

@berzniz
OS Version: macOS Big Sur 11.6.1
OS Appearance: Dark
GitHub version: Enterprise 3.0 (in this version there is no theme preference just the good ol' light theme)
Browser: Chrome Version 96.0.4664.110 (Official Build) (x86_64)
Plugin version: 1.0.36

@matheuskiser Thanks, good tip for now!

@paulmolluzzo
Copy link

I have this issue (or at least something similar). It seems to stem from PR #186 that changed the query that applies dark mode. It respects the system, not the data attr being added by GH when you change themes. The result is that if you choose a dark theme and don't change your system to be in dark mode (or light theme with dark mode enabled) the extension will mismatch the sidebar with the main content.

@RussKie
Copy link

RussKie commented Mar 25, 2024

I hate to revive old threads, but this issue just started happening to me out of a blue in the last week or so...
image

My Windows is running the dark theme so is Edge, however I prefer GitHub in light (for the accessibility reasons) and the extension in the dark theme is rather hard on eyes. It would be great to have the ability to override the theme manually, as right now the extension is quite unusable (inaccessible).
Thank you for the consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants