Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode auto-toggle not working #182

Closed
DiljotSG opened this issue Oct 4, 2021 · 5 comments · Fixed by #186
Closed

Dark mode auto-toggle not working #182

DiljotSG opened this issue Oct 4, 2021 · 5 comments · Fixed by #186

Comments

@DiljotSG
Copy link

DiljotSG commented Oct 4, 2021

I currently have my GitHub in "Sync with System" theme mode and I have my GitHub in "Dark High Contrast" for when my system is in dark mode. Better Pull Request does not respect this setting. When I switch my GitHub to "Single Theme" and disable "Sync With System" only then does Better Pull Request switch to dark styles. Please see the attached screenshot.

image
@berzniz
Copy link
Owner

berzniz commented Oct 10, 2021

Hi @DiljotSG, thanks for reporting.

I'd gladly accept a PR for this if anyone is available to work on it.

@jcheek
Copy link

jcheek commented Nov 23, 2021

+1. I have the same issue and would love to see a fix. If I were to poke around in the code and see if I could fix this, is there any guidance where to start? @berzniz

@ryanrishi ryanrishi mentioned this issue Nov 28, 2021
Merged
@ryanrishi
Copy link
Contributor

PR for the fix: #186

@berzniz
Copy link
Owner

berzniz commented Jan 7, 2022

Thanks @ryanrishi - this planned for the next release

@berzniz
Copy link
Owner

berzniz commented Jan 7, 2022

This will be included soon in 1.0.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new Primer color names ryanrishi/github_pr_tree
4 participants
@berzniz @ryanrishi @jcheek @DiljotSG