Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File tree doesn't strikethrough name of empty file that was deleted #166

Open
t1m0thyj opened this issue Aug 13, 2021 · 3 comments
Open

Comments

@t1m0thyj
Copy link

t1m0thyj commented Aug 13, 2021

First, thank you for making this extension! It makes reviewing PRs a much better experience 🙂

In this PR an empty file .eslintrc was removed. In the file tree, the name should be crossed out but isn't:
image

For other non-empty files that were deleted in the PR, their names are crossed out as expected.

@berzniz
Copy link
Owner

berzniz commented Jan 7, 2022

Thanks for reporting, but the .eslintrc file is not deleted, it exists but has no content (file is empty):
image

While we could also strikethrough empty files, I believe it is not a good depiction of the diff state.

Closing for now.

@berzniz berzniz closed this as completed Jan 7, 2022
@t1m0thyj
Copy link
Author

@berzniz The file is deleted in the PR that I linked:
eslint-deleted

Prior to the PR, .eslintrc was an empty file in the repository. In the PR, the empty .eslintrc file was deleted.

I am not suggesting strikethrough for all empty files, but only for empty files that have been deleted. Could you please consider reopening this issue?

@berzniz berzniz reopened this Jan 10, 2022
@berzniz
Copy link
Owner

berzniz commented Jan 10, 2022

Thanks @t1m0thyj, this makes sense now. Thanks for the detailed explanation. A fix should be pretty simple here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants