Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] red background in tree view #163

Closed
roikoren755 opened this issue Jul 6, 2021 · 17 comments · Fixed by #167
Closed

[bug] red background in tree view #163

roikoren755 opened this issue Jul 6, 2021 · 17 comments · Fixed by #167
Labels
help wanted Extra attention is needed

Comments

@roikoren755
Copy link

I recently started seeing a red background for both the search box at the top of the tree and for the file I'm currently viewing.

This happens in all of the different GitHub themes.

image
image
image
image

@Hacksore
Copy link
Contributor

Hacksore commented Jul 6, 2021

Seems to me like github made this CSS var red now?

background: var(--color-auto-gray-2)

Edit: tried this in incognito on github and it was fine, someone must be conflicting in the extensions then.

background: var(--color-auto-gray-2, var(--bgpr-file-highlight-background))

@krailler
Copy link

krailler commented Jul 7, 2021

I've the same issue 😅

@reececomo
Copy link

Same issue here

@berzniz
Copy link
Owner

berzniz commented Jul 16, 2021

Hi! Thanks for reporting. Can someone experiencing this:

  1. Test on incognito and report if it happens there
  2. List their other installed browser extensions?

I do not see it and it is strange that a variable named gray will be set to red by the GitHub developers them selves.

@Hacksore
Copy link
Contributor

Hacksore commented Jul 16, 2021

This is the issue after confirming it doesn't happen in a non-logged into session as well as just disabling the preview feature.

So if you have the Dark High Contrast feature turned on it's making the tree red for some reason just turn it off for now 😅 .

image

@berzniz
Copy link
Owner

berzniz commented Jul 16, 2021

Thanks @Hacksore - any ideas for a one-size-fits-all solution? If we hard code the value, it will not update between themes. Maybe there's a different CSS variable we should use for that color that is consistent across themes. Open for PRs that fix this

@berzniz berzniz added the help wanted Extra attention is needed label Jul 16, 2021
@roikoren755
Copy link
Author

As seen in my first post, it happens to me in all themes, not just high contrast dark.

I do have a few other extensions running, need to see if disabling some of them will help.

From what I saw, it looks like some scss file didn't load properly, and all of the different color variables get a default value of red.

@sgarner
Copy link

sgarner commented Jul 27, 2021

This is the issue after confirming it doesn't happen in a non logged into session as well as just disabling the preview feature.

So if you have the Dark High Contrast feature turned on it's making the tree red for some reason so turn it off for now 😅 .

image

Confirming that turning off the "Dark High Contrast" Feature Preview resolved this issue for me.

aramperes added a commit to aramperes/github_pr_tree that referenced this issue Aug 25, 2021
@bdwain
Copy link

bdwain commented Aug 26, 2021

i began seeing this issue today but i'm not in dark mode at all, let alone high contrast mode.

here's a list of the extensions installed in incongnito mode, where it also happens.

Screen Shot 2021-08-26 at 1 31 54 AM

@tomdcc
Copy link

tomdcc commented Aug 26, 2021

I too just had this appear today, not using dark mode or high contrast mode. No other extensions enabled for github.com.

@tomdcc
Copy link

tomdcc commented Aug 26, 2021

This is where the red is coming from:

image

image

@berzniz
Copy link
Owner

berzniz commented Aug 26, 2021

Thanks everyone. I guess we can not expect a CSS variable named "gray" to be gray...

I can see it as well. I'd be happy to accept pull requests that handle this. The simpler solution, the better.

@Hacksore
Copy link
Contributor

I'm fairly sure this is a github issue. If you check the network and you load this file it has the bad css, you will see red.

https://github.githubassets.com/assets/colors-v2-0039839a761df7259eecd0c5aa67eabe.css

My understanding is that it's been caused by people opting into the feature preview for high contrast mode but maybe there are other scenarios at this point that load this file.

@berzniz should we open a thread over here to have someone from github look at this?
https://github.community/c/github-help/dark-mode-beta/65

@bdwain
Copy link

bdwain commented Aug 26, 2021

update: even thoughh im not even in dark mode and I never turned on high contrast mode, the feature preview was enabled for me. disabling it fixed the issue

@PederSchacht
Copy link

It appears that the auto vars being used come from https://github.com/primer/primitives and have been deprecated. The auto colors are displaying as red to discourage their use. primer/primitives#121
Screen Shot 2021-08-26 at 12 58 18 PM

@aramperes
Copy link
Contributor

Fix submitted here: #167

@berzniz
Copy link
Owner

berzniz commented Aug 27, 2021

Fix merged (thanks @aramperes) today and submitted to Chrome/Firefox stores as version 1.0.34 — this usually takes a few days to be approved and available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants