Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Display comments left on old commits #140

Open
thombet opened this issue Dec 13, 2020 · 2 comments
Open

[Feature Request] Display comments left on old commits #140

thombet opened this issue Dec 13, 2020 · 2 comments

Comments

@thombet
Copy link

thombet commented Dec 13, 2020

Hello,

First of all thanks for the great work on this extension: it really makes pull requests better in GitHub 😃

Nevertheless I have been struggling when reviewing code on GiHub since the beginning because of the use case described here: https://stackoverflow.com/q/44227100

Is there a way to make the handling of this use case better by adding a new feature in this extension?

Thanks in advance!

@berzniz
Copy link
Owner

berzniz commented Dec 13, 2020

Thanks @thombet for the suggestion.

The extension currently works by collecting information from the page itself (by reading the DOM). If the outdated comments information is not there, it will require a change in how the extension collects the information (maybe using API calls).

If anyone wants to take a try, I would accept a PR fort his. Worth detailing first what you're planning to achieve.

@thombet
Copy link
Author

thombet commented Feb 4, 2021

I'm almost sure this information is not in the DOM otherwise GitHub would probably display it already.
Unfortunately I would not be able to help implementing this...

If it helps, I think the use case is very well described in the link above.
In a nutshell he solution I'm looking for is to be able to display the comments that were posted on a specific commit in the "Flies changed" view of a PR, even if they are outdated.

Coming from Gerrit, I'm quite surprised that neither GitHub nor any extension implemented this already as it really ensure you check all the review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants