Skip to content

Commit 1c130c4

Browse files
authored
Merge pull request #131 from berty/fix/read-max-size
2 parents abc7b33 + 62a3ff0 commit 1c130c4

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pubsub/directchannel/channel.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
)
1717

1818
const PROTOCOL = "/go-orbit-db/direct-channel/1.2.0"
19-
const DelimitedReadMaxSize = 2048
19+
const DelimitedReadMaxSize = 1024 * 1024 * 4 // mb
2020

2121
type directChannel struct {
2222
logger *zap.Logger
@@ -57,8 +57,9 @@ func (d *directChannel) handleNewPeer(s network.Stream) {
5757
}
5858

5959
length := int(length64)
60-
if length < 0 || length > DelimitedReadMaxSize {
61-
d.logger.Error("invalid buffer length", zap.Error(io.ErrShortBuffer))
60+
61+
if length > DelimitedReadMaxSize {
62+
d.logger.Error(fmt.Sprintf("received data exceeding maximum allowed size (%d > %d)", length, DelimitedReadMaxSize))
6263
return
6364
}
6465

0 commit comments

Comments
 (0)