Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: If node addition during autoscaling fails, autoscaler does not recognized this #1657

Closed
Despire opened this issue Feb 17, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Despire
Copy link
Contributor

Despire commented Feb 17, 2025

Current Behaviour

Currently if the autoscaling event triggered an addition of a new node into the cluster, and that node fails to be added, autoscaler will think that the node was added successfully.

Expected Behaviour

Autoscaler should only consider the addition of a node to be successful when the node is actually joined to the cluster.

Steps To Reproduce

  1. Build a cluster with autoscaled nodepool
  2. trigger an addition of a new node
  3. intentionally make the addition fail.
  4. see that autoscaler will think that the node was added and will not request a new scaleup/scaledown.
@Despire Despire added the bug Something isn't working label Feb 17, 2025
@Despire
Copy link
Contributor Author

Despire commented Feb 17, 2025

Closing this, as I was testing features in #1631 and this issue is related to those features, which will be fixed

@Despire Despire closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant