-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate back to Cloudflare Workers #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a75c372
to
1518553
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #147 +/- ##
==========================================
- Coverage 87.00% 86.47% -0.54%
==========================================
Files 38 37 -1
Lines 2439 2454 +15
Branches 302 301 -1
==========================================
Hits 2122 2122
- Misses 309 325 +16
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. |
benvinegar
added a commit
that referenced
this pull request
Jan 24, 2025
* Migrate back to Cloudflare Workers * Delete deprecated CF pages files
benvinegar
added a commit
that referenced
this pull request
Jan 25, 2025
* Migrate back to Cloudflare Workers * Delete deprecated CF pages files
benvinegar
added a commit
that referenced
this pull request
Jan 26, 2025
* Migrate back to Cloudflare Workers * Delete deprecated CF pages files
benvinegar
added a commit
that referenced
this pull request
Feb 6, 2025
* Migrate back to Cloudflare Workers (#147) * Migrate back to Cloudflare Workers * Delete deprecated CF pages files * First attempt at CLI * CLI checks if env variables already set first * Add loading spinner (ora pkg) to CLI * Create .counterscale dir * Update commands for new Turbo layout * Put CLI colors in constant * Create db in home dir * Get account id * Store worker in db, pass as wrangler CLI param * Use shell exec variable substitution * More messin around * Remove sqlite/db code * Dont prompt for Cloudflare account id, fix errors not emitting * Fix a host of issues * Add cli package * Add inquirer types * Fix parsing account id * Try to figure out where @counterscale/server is located * Add missing package.json fields and LICENSE * Fix bad dep * More package/dist fixes for CLI install * alpha 4 * Back to wrangler.json * alpha 5 * alpha 6 * fix paths + alpha 7 * alpha 8 * bundle app w/ server pkg, alpha 9 * Get default names from wrangler.json * Better styling + colors * Tick out output so it looks more natural * Remove test boilerplate from cli (no tests yet) * Fix tests, lint, typecheck * Add basic test suite for CLI * Add more tests * Make wrangler a peerdep * Switch to pnpm to solve subdep issues * Fix missing ora dep * Add npmrc, link workspace packages, add node types * Fix tests * Fix eslint * Fix path resolution * alpha 12 * Fix relative path in import
benvinegar
added a commit
that referenced
this pull request
Feb 6, 2025
* Migrate back to Cloudflare Workers (#147) * Migrate back to Cloudflare Workers * Delete deprecated CF pages files * First attempt at CLI * CLI checks if env variables already set first * Add loading spinner (ora pkg) to CLI * Create .counterscale dir * Update commands for new Turbo layout * Put CLI colors in constant * Create db in home dir * Get account id * Store worker in db, pass as wrangler CLI param * Use shell exec variable substitution * More messin around * Remove sqlite/db code * Dont prompt for Cloudflare account id, fix errors not emitting * Fix a host of issues * Add cli package * Add inquirer types * Fix parsing account id * Try to figure out where @counterscale/server is located * Add missing package.json fields and LICENSE * Fix bad dep * More package/dist fixes for CLI install * alpha 4 * Back to wrangler.json * alpha 5 * alpha 6 * fix paths + alpha 7 * alpha 8 * bundle app w/ server pkg, alpha 9 * Get default names from wrangler.json * Better styling + colors * Tick out output so it looks more natural * Remove test boilerplate from cli (no tests yet) * Fix tests, lint, typecheck * Add basic test suite for CLI * Add more tests * Make wrangler a peerdep * Switch to pnpm to solve subdep issues * Fix missing ora dep * Add npmrc, link workspace packages, add node types * Fix tests * Fix eslint * Fix path resolution * alpha 12 * Fix relative path in import
benvinegar
added a commit
that referenced
this pull request
Feb 6, 2025
* Migrate back to Cloudflare Workers * Delete deprecated CF pages files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134.
This would introduce breaking changes because it deploys to a Cloudflare Worker instead of a Pages project – you would need to create the Worker. But the good news is the data (Analytics Engine) will be unaffected.
Not sure I want to introduce another major version (3.x) for this though.