update method in MACD.ts does not reflect replace argument

[asamaru7]

In the MACD.ts file, within the update(_price: BigSource, replace: boolean = false): void | MACDResult method, the replace argument is not being applied correctly. Specifically, the line:

const signal = this.signal.update(macd);

should be updated to:

const signal = this.signal.update(macd, replace);

This change ensures that the replace flag is properly passed to the update method of this.signal.

[bennycode]

@asamaru7 thanks for the finding. Can you please send a Pull Request to fix this?

[asamaru7]

@bennycode

While working on fixing the MACD-related issue, I forked the repository and noticed that similar problems seem to exist in other parts of the codebase.

I might be misunderstanding the specific roles of each source file, but the files where I observed potential issues in the update function are:

• AC.ts
• ADX.ts
• CCI.ts
• StochasticRSI.ts
• WSMA.ts

Given that similar problems appear in multiple places, I believe it would be better for someone familiar with the overall structure and purpose of each source file to conduct a comprehensive review. Additionally, there might be other similar issues in areas I haven't looked into yet.

[bennycode]

Thank you for your investigation, @asamaru7.

I build some test cases (#734) and indeed the signal line and histogram are off when replacing values. Need to figure out where this comes from. 🤔