Skip to content

Commit 93d405a

Browse files
committed
Remove Node.js v10 from test rotation.
The `@wry/*` packages are all believed to work in Node 10, but that Node.js version has been end-of-life'd (even for security updates) since April 2021: https://endoflife.date/nodejs Removing v10 should fix the tests in PR #230, which are broken because Node 10 does not understand class property syntax in the `tests.cjs.js` bundle. The main `@wry/equality` library continues to be compiled to es2015, eliminating class syntax, but the tests need to be compiled to esnext to test generator and async function equality. There may be a way to satisfy both of these constraints, but the easiest solution right now is to avoid testing in Node 10.
1 parent 9a93312 commit 93d405a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ${{ matrix.os }}
1313
strategy:
1414
matrix:
15-
node_version: ['10', '12', '14', '15', '16']
15+
node_version: ['12', '14', '15', '16']
1616
os: [ubuntu-latest]
1717

1818
steps:

0 commit comments

Comments
 (0)