Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show ellipsis if entire text is less than number of elements to show? #12

Open
Trevoke opened this issue Jun 15, 2016 · 8 comments

Comments

@Trevoke
Copy link
Contributor

Trevoke commented Jun 15, 2016

The text I have to display is highly variable; I can check its length and use this component or a regular div, but it would be so much nicer if this component just "did the right thing" :)

@bebraw
Copy link
Owner

bebraw commented Jun 15, 2016

Yeah. That sounds like sane behavior to me. Please PR. 👍

@Trevoke
Copy link
Contributor Author

Trevoke commented Jun 16, 2016

Hi,

My schedule will not allow me to work on this for at least fifteen days, and by then I will not be working on React / Redux anymore. While I might be able to contribute, I'm afraid you can't count on me to do this.

@bebraw
Copy link
Owner

bebraw commented Jun 16, 2016

No problem. I'll hack together something quick for these. Simple enough. 👍

@stahlmanDesign
Copy link

@bebraw did you ever work on this solution?

@bebraw
Copy link
Owner

bebraw commented Dec 2, 2016

@stahlmanDesign Nope, too busy and I forgot the issue. If you want, I can get the project up to date so it's easy to work with.

@stahlmanDesign
Copy link

That would be great, I'll give it a shot

@bebraw
Copy link
Owner

bebraw commented Dec 5, 2016

@stahlmanDesign I updated the setup. Pretty big change but worth it.

On a related note, maybe it would be a good idea to drop state from the component and control it from outside. This would allow us to go stateless style (function) and keep the component even simpler.

@bebraw
Copy link
Owner

bebraw commented Dec 5, 2016

I ended up going stateless as that was a simple change to do. Easier code as well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants