-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show ellipsis if entire text is less than number of elements to show? #12
Comments
Yeah. That sounds like sane behavior to me. Please PR. 👍 |
Hi, My schedule will not allow me to work on this for at least fifteen days, and by then I will not be working on React / Redux anymore. While I might be able to contribute, I'm afraid you can't count on me to do this. |
No problem. I'll hack together something quick for these. Simple enough. 👍 |
@bebraw did you ever work on this solution? |
@stahlmanDesign Nope, too busy and I forgot the issue. If you want, I can get the project up to date so it's easy to work with. |
That would be great, I'll give it a shot |
@stahlmanDesign I updated the setup. Pretty big change but worth it. On a related note, maybe it would be a good idea to drop state from the component and control it from outside. This would allow us to go stateless style (function) and keep the component even simpler. |
I ended up going stateless as that was a simple change to do. Easier code as well now. |
The text I have to display is highly variable; I can check its length and use this component or a regular div, but it would be so much nicer if this component just "did the right thing" :)
The text was updated successfully, but these errors were encountered: