Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show less" ? #11

Open
Trevoke opened this issue Jun 15, 2016 · 2 comments
Open

"Show less" ? #11

Trevoke opened this issue Jun 15, 2016 · 2 comments

Comments

@Trevoke
Copy link
Contributor

Trevoke commented Jun 15, 2016

It would be nice to be able to specify a "show less" element for when the entire text is displayed, to bring us back to the shortened display.

@bebraw
Copy link
Owner

bebraw commented Jun 15, 2016

Great idea. Now we have more='…' moreClass='more'. I would refactor this so that we have

more={<span className="more"></span>}
less={<span className="less"></span>}

instead. So accept arbitrary JSX for maximum customizability. It can accept strings and/or numbers too. This is a breaking change, but it would give us a saner API.

Do you want to PR this?

@Trevoke
Copy link
Contributor Author

Trevoke commented Jun 16, 2016

Hi,

My schedule will not allow me to work on this for at least fifteen days, and by then I will not be working on React / Redux anymore. While I might be able to contribute, I'm afraid you can't count on me to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants