Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show-accounts-with-zero-transactions False sometimes ignored #1941

Closed
mdlaat opened this issue Jan 5, 2025 · 1 comment
Closed

show-accounts-with-zero-transactions False sometimes ignored #1941

mdlaat opened this issue Jan 5, 2025 · 1 comment
Labels

Comments

@mdlaat
Copy link

mdlaat commented Jan 5, 2025

Thank you for this great tool!

Since updating from fava v1.28 to v1.30 I am seeing sometimes the setting "show-accounts-with-zero-transactions False" being ignored. Here is how I experience that:

  • With no filter (top right of screen) active, go to income statement. This is displayed as it should.
  • While on that screen, set a filter (in my case I type in the left of the 3 boxes '2025' to add a filter to this year)
  • You now see an income statement as if show-accounts-with-zero-transactions was true (but it is still set as false)
  • Press F5 to refresh the browser screen. Note that the filter is still active (as expected)
  • You now see a correct income statement, honoring "show-accounts-with-zero-transactions False"
@yagebu yagebu added the bug label Jan 6, 2025
@yagebu
Copy link
Member

yagebu commented Jan 6, 2025

Thanks for the report - I think this got broken in the upgrade to Svelte 5, will be fixed in #1942

@yagebu yagebu closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants