From 00973e72e6e599780d69c66f708ebda61f5c8c52 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:12:50 +0200 Subject: [PATCH 01/14] Update pubspec.yaml --- pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index 0eb6193d..b502d643 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,9 +1,9 @@ name: pointycastle -version: 3.8.0 +version: 3.9.0 description: A Dart library implementing cryptographic algorithms and primitives, modeled on the BouncyCastle library. homepage: https://github.com/bcgit/pc-dart environment: - sdk: ^3.0.0 + sdk: ^3.1.0 dependencies: collection: ^1.15.0 From df4d1d7d578bb3bca47b4c27916d79d6928f661f Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:18:42 +0200 Subject: [PATCH 02/14] Fix workflows --- .github/workflows/chrome.workflow.yml | 9 +++++++-- .github/workflows/node.workflow.yml | 9 +++++++-- .github/workflows/vm.workflow.yml | 9 +++++++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index 4cdee531..d355a1c0 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -20,12 +20,17 @@ jobs: build: # The type of runner that the job will run on runs-on: ubuntu-latest + strategy: + matrix: + sdk: [3.0.0, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v3 - - uses: dart-lang/setup-dart@v1 + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 + - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 + with: + sdk: ${{ matrix.sdk }} - name: Install dependencies run: dart pub get diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 9694ba9f..4056def8 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -20,12 +20,17 @@ jobs: build: # The type of runner that the job will run on runs-on: ubuntu-latest + strategy: + matrix: + sdk: [3.0.0, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v3 - - uses: dart-lang/setup-dart@v1 + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 + - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 + with: + sdk: ${{ matrix.sdk }} - name: Install dependencies run: dart pub get diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index 791b7e1f..6ce4ba13 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -20,12 +20,17 @@ jobs: build: # The type of runner that the job will run on runs-on: ubuntu-latest + strategy: + matrix: + sdk: [3.0.0, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v3 - - uses: dart-lang/setup-dart@v1 + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 + - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 + with: + sdk: ${{ matrix.sdk }} - name: Install dependencies run: dart pub get From b39f52e1c371ca7e08b11f044b6f3860b6b0d2f6 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:20:07 +0200 Subject: [PATCH 03/14] Revert SDK dep upgrade --- pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index b502d643..0eb6193d 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,9 +1,9 @@ name: pointycastle -version: 3.9.0 +version: 3.8.0 description: A Dart library implementing cryptographic algorithms and primitives, modeled on the BouncyCastle library. homepage: https://github.com/bcgit/pc-dart environment: - sdk: ^3.1.0 + sdk: ^3.0.0 dependencies: collection: ^1.15.0 From 5482b4e5cbfdd5247c8bb4716cd9ca5d66da7db4 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:26:11 +0200 Subject: [PATCH 04/14] Rev SDK version --- pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index 0eb6193d..b502d643 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,9 +1,9 @@ name: pointycastle -version: 3.8.0 +version: 3.9.0 description: A Dart library implementing cryptographic algorithms and primitives, modeled on the BouncyCastle library. homepage: https://github.com/bcgit/pc-dart environment: - sdk: ^3.0.0 + sdk: ^3.1.0 dependencies: collection: ^1.15.0 From 0b76fa2c9b90c712ec59574412f9ff1818525a69 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:26:22 +0200 Subject: [PATCH 05/14] Switch to `dart test` --- .github/workflows/chrome.workflow.yml | 4 ++-- .github/workflows/node.workflow.yml | 4 ++-- .github/workflows/vm.workflow.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index d355a1c0..5d6ff568 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.0.0, dev] + sdk: [3.1.0, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: @@ -36,4 +36,4 @@ jobs: run: dart pub get - name: Test chrome - run: dart pub run test -j 1 -p chrome + run: dart test -j 1 -p chrome diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 4056def8..8280fdd3 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.0.0, dev] + sdk: [3.1.0, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: @@ -36,4 +36,4 @@ jobs: run: dart pub get - name: Test node - run: dart pub run test -p node + run: dart test -p node diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index 6ce4ba13..4dc3030d 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.0.0, dev] + sdk: [3.1.0, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: @@ -36,4 +36,4 @@ jobs: run: dart pub get - name: Test dartvm - run: dart pub run test -p vm + run: dart test -p vm From 7b9b21a8bb08bfbe7b6c4eee30f08d52425d9994 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:26:30 +0200 Subject: [PATCH 06/14] Add health workflow --- .github/workflows/health.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/workflows/health.yaml diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml new file mode 100644 index 00000000..f05330c8 --- /dev/null +++ b/.github/workflows/health.yaml @@ -0,0 +1,12 @@ +name: Health +on: + pull_request: + branches: [ main ] + types: [opened, synchronize, reopened, labeled, unlabeled] +jobs: + health: + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + with: + checks: "version,changelog,license,do-not-submit,breaking,coverage,leaking" + permissions: + pull-requests: write \ No newline at end of file From 9e5fc5c6fbc8c164a6e52ce6d5c2710c444f0199 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:27:25 +0200 Subject: [PATCH 07/14] Pin health workflow --- .github/workflows/health.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index f05330c8..e35f6573 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -5,7 +5,7 @@ on: types: [opened, synchronize, reopened, labeled, unlabeled] jobs: health: - uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + uses: dart-lang/ecosystem/.github/workflows/health.yaml@9fabe464ea1d8408774de74d2ac759c1f90ae480 with: checks: "version,changelog,license,do-not-submit,breaking,coverage,leaking" permissions: From 49fe90482f275fd177c58ccf05a254453958a8d7 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:28:49 +0200 Subject: [PATCH 08/14] Add workflow to comment on PRs --- .github/workflows/post_summaries.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/workflows/post_summaries.yaml diff --git a/.github/workflows/post_summaries.yaml b/.github/workflows/post_summaries.yaml new file mode 100644 index 00000000..fac7e539 --- /dev/null +++ b/.github/workflows/post_summaries.yaml @@ -0,0 +1,16 @@ +name: Comment on the pull request + +on: + # Trigger this workflow after the Health workflow completes. This workflow will have permissions to + # do things like create comments on the PR, even if the original workflow couldn't. + workflow_run: + workflows: + - Health + types: + - completed + +jobs: + upload: + uses: dart-lang/ecosystem/.github/workflows/post_summaries.yaml@main + permissions: + pull-requests: write \ No newline at end of file From 50a1559a1356c293e1865eb29f7adc09d78aa86e Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 10:39:32 +0200 Subject: [PATCH 09/14] Also include stable in testing --- .github/workflows/chrome.workflow.yml | 2 +- .github/workflows/node.workflow.yml | 2 +- .github/workflows/vm.workflow.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index 5d6ff568..45d389d6 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.1.0, dev] + sdk: [3.1.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 8280fdd3..612da390 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.1.0, dev] + sdk: [3.1.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index 4dc3030d..99182ce5 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.1.0, dev] + sdk: [3.1.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: From d230491e727dac21e3ee1bb49ab9355b6bcfe7cb Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 11:04:41 +0200 Subject: [PATCH 10/14] Rev min SDK --- .github/workflows/chrome.workflow.yml | 2 +- .github/workflows/node.workflow.yml | 2 +- .github/workflows/vm.workflow.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index 45d389d6..c1c81da5 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.1.0, stable, dev] + sdk: [3.3.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 612da390..4a1a18c3 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.1.0, stable, dev] + sdk: [3.3.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index 99182ce5..e5a09609 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.1.0, stable, dev] + sdk: [3.3.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: From 5cb3ac74a5651c0e1629de8fe9055676b9626f91 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 11:05:30 +0200 Subject: [PATCH 11/14] Change gh action SDKs --- .github/workflows/chrome.workflow.yml | 2 +- .github/workflows/node.workflow.yml | 2 +- .github/workflows/vm.workflow.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index c1c81da5..c68e0bf7 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.3.0, stable, dev] + sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 4a1a18c3..4e307454 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.3.0, stable, dev] + sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index e5a09609..d51a12e0 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - sdk: [3.3.0, stable, dev] + sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: From 122edc55762b60dd68c17b1800dfae6dd3270c43 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 11:06:29 +0200 Subject: [PATCH 12/14] Don't fail fast --- .github/workflows/chrome.workflow.yml | 1 + .github/workflows/node.workflow.yml | 1 + .github/workflows/vm.workflow.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index c68e0bf7..69acbb34 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -21,6 +21,7 @@ jobs: # The type of runner that the job will run on runs-on: ubuntu-latest strategy: + fail-fast: false matrix: sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 4e307454..9cbeffbb 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -21,6 +21,7 @@ jobs: # The type of runner that the job will run on runs-on: ubuntu-latest strategy: + fail-fast: false matrix: sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index d51a12e0..e29d036b 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -21,6 +21,7 @@ jobs: # The type of runner that the job will run on runs-on: ubuntu-latest strategy: + fail-fast: false matrix: sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] From 4787d73339c1aa721b4890c509b05a05cd0ed148 Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 13:36:50 +0200 Subject: [PATCH 13/14] Set min SDK to 3.2.0 --- .github/workflows/chrome.workflow.yml | 2 +- .github/workflows/node.workflow.yml | 2 +- .github/workflows/vm.workflow.yml | 2 +- pubspec.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/chrome.workflow.yml b/.github/workflows/chrome.workflow.yml index 69acbb34..4e5bbafd 100644 --- a/.github/workflows/chrome.workflow.yml +++ b/.github/workflows/chrome.workflow.yml @@ -23,7 +23,7 @@ jobs: strategy: fail-fast: false matrix: - sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] + sdk: [3.2.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/node.workflow.yml b/.github/workflows/node.workflow.yml index 9cbeffbb..53996c61 100644 --- a/.github/workflows/node.workflow.yml +++ b/.github/workflows/node.workflow.yml @@ -23,7 +23,7 @@ jobs: strategy: fail-fast: false matrix: - sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] + sdk: [3.2.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index e29d036b..41375a29 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -23,7 +23,7 @@ jobs: strategy: fail-fast: false matrix: - sdk: [3.1.0, 3.2.0, 3.3.0, stable, dev] + sdk: [3.2.0, stable, dev] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/pubspec.yaml b/pubspec.yaml index b502d643..51ebd1b9 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -3,7 +3,7 @@ version: 3.9.0 description: A Dart library implementing cryptographic algorithms and primitives, modeled on the BouncyCastle library. homepage: https://github.com/bcgit/pc-dart environment: - sdk: ^3.1.0 + sdk: ^3.2.0 dependencies: collection: ^1.15.0 From d6086d8563a5beeb06d42698c574ceb9fef904cf Mon Sep 17 00:00:00 2001 From: Moritz <mosum@google.com> Date: Mon, 15 Apr 2024 13:41:57 +0200 Subject: [PATCH 14/14] Run vm on all three platforms --- .github/workflows/vm.workflow.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/vm.workflow.yml b/.github/workflows/vm.workflow.yml index 41375a29..0c3b9e6b 100644 --- a/.github/workflows/vm.workflow.yml +++ b/.github/workflows/vm.workflow.yml @@ -19,11 +19,18 @@ jobs: # This workflow contains a single job called "build" build: # The type of runner that the job will run on - runs-on: ubuntu-latest strategy: fail-fast: false matrix: - sdk: [3.2.0, stable, dev] + os: [ubuntu, macos, windows] + sdk: [stable] + include: + - os: ubuntu + sdk: 3.2.0 + - os: ubuntu + sdk: dev + + runs-on: ${{ matrix.os }}-latest # Steps represent a sequence of tasks that will be executed as part of the job steps: