Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute.att_gt trimming due to pscore_problems_likely not applied when panel=FALSE #193

Open
ransiw opened this issue Mar 16, 2024 · 0 comments

Comments

@ransiw
Copy link

ransiw commented Mar 16, 2024

With balanced panels when overlap is violated (lines 218 to 221 in compute.att_gt) the relevant treatment unit is excluded.

if (reg_problems_likely | pscore_problems_likely) {

But this is not applied with unbalanced panels when panel=FALSE. After line 318 in compute.att_gt, the estimation starts and no checks for overlap happen.

Is there a reason why this was not implemented for when panel=FALSE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant