Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

semantic: string literal escape sequence handing #75

Closed
1 of 3 tasks
bzz opened this issue Mar 21, 2019 · 1 comment
Closed
1 of 3 tasks

semantic: string literal escape sequence handing #75

bzz opened this issue Mar 21, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@bzz
Copy link
Contributor

bzz commented Mar 21, 2019

Discovered as part of the bblfsh/bblfshd#268 (comment)

This is an ☂️ issue for multiple driver failures \w invalid syntax.

E.g driver fails to parse e.g this file with

     check: key "value": invalid syntax

Normalization mapping for semantic mode needs to be updated.

132 file examples could be obtained using

grep "language=javascript$" bblfshd.log | grep -oP "rpc error: code = \K(.*)" | grep "invalid syntax" | sort | less
@bzz bzz added the bug label Mar 21, 2019
@bzz bzz added this to the v2.7.2 milestone Mar 21, 2019
@bzz bzz modified the milestone: v2.7.x Mar 26, 2019
@bzz bzz self-assigned this Mar 26, 2019
bzz added a commit to bzz/javascript-driver that referenced this issue Mar 26, 2019
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz
Copy link
Contributor Author

bzz commented Mar 28, 2019

PR description updated to become an ☂️ issue with multiple PRs fixing it.

@bzz bzz modified the milestones: v2.7.3, v2.7.x Apr 9, 2019
@bzz bzz changed the title check: key "value": invalid syntax semantic: string literal escape sequence handing Apr 15, 2019
@bzz bzz closed this as completed in 683324b Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant