-
Notifications
You must be signed in to change notification settings - Fork 30
Point to enry and github/linguist #191
Comments
This is actually not true that you need to know the language to parse files. Bblfshd will autodetect it if it's empty. Need to clarify this. |
@dennwc Sure, but when you specify a language, we use language names as defined in enry. |
This is actually not true (currently) for Bash: bblfsh/bash-driver#39 (comment) |
Could somebody please help me understand, what are the action items here now? If that is to mention the language auto-detection + usage of enry/linguist language names on client API level - would https://docs.sourced.tech/babelfish/using-babelfish/clients be a good place for adding a new section on language detection? (Open to any other suggestions as well) |
@bzz IMHO it would be mentioning how the language field works in requests:
Not sure if it belongs to client or to the protocol description. Or even both. |
@smola I see! But could you please help me understand how is that different from what we have in https://docs.sourced.tech/babelfish/using-babelfish/babelfish-protocol#parserequest ?
From what I can see, it's:
If that is all that's needed - will be happy to add it asap. |
@bzz Yeah, a mention to the key would be enough I guess. Also, mention what's the behaviour regarding case sensitiveness (or lack of it). |
From @ajnavarro yesterday (more):
Somewhere in the documentation we should clarify that when we choose language keys, we use github/linguist as reference (languages.yml) and both enry in Go and linguist in Ruby will do the job if language detection is needed before passing to Babelfish.
The text was updated successfully, but these errors were encountered: