Make tests pass on Windows (#1529)

* Make tests pass on Windows
Bunch of changes. Here's some highlights:

Code Changes
- Refactored ScalacWorker to abstract common code between Scala 2 & 3
- Refactored dependency-analyzer plugin javaargs to use ‘;’ as a delimiter instead of ‘:’
- Renamed a couple function names containing rpathlocation to rlocationpath
- added lineEndings=preserve to scalafmt.conf
- added .bazelrc to enable needed flags for Windows

Test Changes
- disable running tests for features not-supported on Windows
- make tests handle fact that sh_binary outputs .exe on Windows
- Handle other Windows specifics where needed (i.e. backslash as pathseparator, crlf linendings, dependence on bash)

* Fixed some minor nits

Author: crt-31

.bazelrc

@@ -0,0 +1,5 @@
+build --enable_platform_specific_config
+
+#Windows needs --worker_quit_after_build due to workers not being shut down when the compiler tools need to be rebuilt (resulting in 'file in use' errors). See Bazel Issue#10498.
+
+build:windows --worker_quit_after_build --enable_runfiles 

.scalafmt.conf

@@ -13,3 +13,4 @@ rewrite.rules = [
   SortImports
 ]
 unindentTopLevelOperators = false
+lineEndings=preserve

dt_patches/dt_patch_test.sh

@@ -17,6 +17,7 @@ run_test_local() {
   if [ $RESPONSE_CODE -eq 0 ]; then
     echo -e "${GREEN} Test \"$TEST_ARG\" successful ($DURATION sec) $NC"
   else
+    echo $RES
     echo -e "${RED} Test \"$TEST_ARG\" failed $NC ($DURATION sec) $NC"
     return $RESPONSE_CODE
   fi
@@ -26,9 +27,12 @@ run_in_test_repo() {
   local test_command=$1
   local test_repo=$2
 
-  cd "${dir}/${test_repo}" || exit 1
+  cd "${dir}/${test_repo}" || exit 1 
   ${test_command}
   RESPONSE_CODE=$?
+
+  bazel shutdown
+  
   cd ../..
 
   return $RESPONSE_CODE

dt_patches/test_dt_patches/.bazelrc

@@ -0,0 +1 @@
+import ../../.bazelrc

dt_patches/test_dt_patches_user_srcjar/.bazelrc

@@ -0,0 +1 @@
+import ../../.bazelrc

examples/testing/multi_frameworks_toolchain/.bazelrc

@@ -0,0 +1,2 @@
+build --enable_platform_specific_config
+windows:build --enable_runfiles

examples/testing/specs2_junit_repositories/.bazelrc

@@ -0,0 +1,2 @@
+build --enable_platform_specific_config
+windows:build --enable_runfiles

scala/private/common.bzl

@@ -136,7 +136,11 @@ def sanitize_string_for_usage(s):
             res_array.append("_")
     return "".join(res_array)
 
-#generates rpathlocation that should be used with the rlocation() at runtime. (rpathlocations start with repo name)
+#generates an rlocationpath that can be used with the rlocation() at runtime. (rlocationpath starts with repo name)
+def rlocationpath_from_file(ctx, file):
+    return paths.normalize(ctx.workspace_name + "/" + file.short_path)
+
+#generates an rlocationpath that can be used with the rlocation() at runtime. (rlocationpath start with repo name)
 #rootpath arg expects "rootpath" format (i.e. relative to runfilesDir/workspacename). Rootpath can be obtained by $rootpath macro or File.short_path
-def rpathlocation_from_rootpath(ctx, rootpath):
+def rlocationpath_from_rootpath(ctx, rootpath):
     return paths.normalize(ctx.workspace_name + "/" + rootpath)

scala/private/rule_impls.bzl

@@ -15,7 +15,7 @@
 
 load("@bazel_skylib//lib:paths.bzl", "paths")
 load("@bazel_tools//tools/jdk:toolchain_utils.bzl", "find_java_toolchain")
-load(":common.bzl", "rpathlocation_from_rootpath", _collect_plugin_paths = "collect_plugin_paths")
+load(":common.bzl", "rlocationpath_from_rootpath", _collect_plugin_paths = "collect_plugin_paths")
 load(":resources.bzl", _resource_paths = "paths")
 
 def expand_location(ctx, flags):
@@ -213,7 +213,7 @@ def java_bin_windows(ctx):
     if paths.is_absolute(java_runtime.java_executable_runfiles_path):
         java_bin = java_runtime.java_executable_runfiles_path
     else:
-        java_bin = rpathlocation_from_rootpath(ctx, java_runtime.java_executable_runfiles_path)
+        java_bin = rlocationpath_from_rootpath(ctx, java_runtime.java_executable_runfiles_path)
 
     return java_bin
 

src/java/io/bazel/rulesscala/exe/LauncherFileWriter.java

@@ -31,8 +31,8 @@ public static void main(String[] args) throws IOException {
             .addKeyValuePair("binary_type", "Java")
             .addKeyValuePair("workspace_name", workspaceName)
             .addKeyValuePair("symlink_runfiles_enabled", "0")
-            .addKeyValuePair("java_bin_path", javaBinPath.replace("\\", "/")) //Expects rpathlocation (i.e. with prepended repo name)
-            .addKeyValuePair("jar_bin_path", rpathlocation_to_rootpath( workspaceName, jarBinPath)) //Expects rootpath location 
+            .addKeyValuePair("java_bin_path", javaBinPath.replace("\\", "/")) //Expects rlocationpath (i.e. with prepended repo name)
+            .addKeyValuePair("jar_bin_path", rlocationpath_to_rootpath( workspaceName, jarBinPath)) //Expects rootpath location 
             .addKeyValuePair("java_start_class", javaStartClass)
             .addKeyValuePair("classpath", classpath) //Expects rootpath location
             .addJoinedValues("jvm_flags", "\t", jvmFlags)
@@ -56,9 +56,9 @@ public static void main(String[] args) throws IOException {
     }
   }
 
-  //Bazel's java_launcher expects some fields(i.e. jar_bin_path and classpaths) to be rootpath. rpathlocation is relative to runfiledir (always prefix with repo). Rootpath is relative to runfiledir/workspacename. 
-  static String rpathlocation_to_rootpath(String workspaceName, String rpathlocation){
-    Path path = Paths.get(rpathlocation);
+  //Bazel's java_launcher expects some fields(i.e. jar_bin_path and classpaths) to be rootpath. rlocationpath is relative to runfiledir (always prefix with repo). Rootpath is relative to runfiledir/workspacename. 
+  static String rlocationpath_to_rootpath(String workspaceName, String rlocationpath){
+    Path path = Paths.get(rlocationpath);
 
     Path result;
     if(!path.startsWith(workspaceName)){