From b5df3c0ba80a08f66f9adb036ec1f2f2139fc789 Mon Sep 17 00:00:00 2001 From: Dennis Ameling Date: Tue, 19 Aug 2025 19:50:02 +0200 Subject: [PATCH] fix: add missing windows arm64 in os_arch_names A previous commit added support for Windows arm64, but I forgot to add it to OS_ARCH_NAMES, so it's not _actually_ working yet. This commit adds it. Ref: https://github.com/bazel-contrib/rules_nodejs/commit/12d90ecf8d2e5431a531b476cfeaa06b6a4e5f50 --- nodejs/private/os_name.bzl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nodejs/private/os_name.bzl b/nodejs/private/os_name.bzl index bb0619e8dc..7d901fd949 100644 --- a/nodejs/private/os_name.bzl +++ b/nodejs/private/os_name.bzl @@ -19,6 +19,7 @@ load(":node_versions.bzl", "NODE_VERSIONS") OS_ARCH_NAMES = [ ("windows", "amd64"), + ("windows", "arm64"), ("darwin", "amd64"), ("darwin", "arm64"), ("linux", "amd64"), @@ -78,4 +79,4 @@ def assert_node_exists_for_host(rctx): if not node_exists_for_os(node_version, os_name(rctx), node_repositories): fail("No nodejs is available for {} at version {}".format(os_name(rctx), node_version) + "\n Consider upgrading by setting node_version in a call to node_repositories in WORKSPACE." + - "\n Note that Node 16.x is the minimum published for Apple Silicon (M1 Macs)") + "\n Note that Node 16.x is the minimum published for Apple Silicon (M1 Macs), and 20.x is the minimum for Windows ARM64.")