Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of bazel_tools/conditions with @platform #2440

Open
mattem opened this issue Feb 2, 2021 · 2 comments
Open

Replace use of bazel_tools/conditions with @platform #2440

mattem opened this issue Feb 2, 2021 · 2 comments
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
6.0

Comments

@mattem
Copy link
Collaborator

mattem commented Feb 2, 2021

Replace use of bazel_tools/conditions with @platform and flip incompatible_use_platforms_repo_for_constraints

See bazelbuild/bazel#8622
@mattem mattem added help wanted cleanup Tech debt, resolving it improves our own velocity labels Feb 2, 2021
@mattem mattem mentioned this issue Feb 2, 2021
Merged
@alexeagle alexeagle added this to the 5.0 milestone Oct 14, 2021
@thesayyn thesayyn mentioned this issue Dec 19, 2021
Closed
12 tasks
@alexeagle alexeagle modified the milestones: 5.0, 6.0 Jan 12, 2022
@alexeagle
Copy link
Collaborator

Slipping this to next release, I don't think anything requires that it happens before then.

@gregmagolan
Copy link
Collaborator

Looks like there are still some users of @bazel_tools//src/conditions in e2e tests so leaving this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
4 participants
@alexeagle @gregmagolan @mattem @thesayyn