Skip to content

Commit 23f995b

Browse files
committed
some typing nits
1 parent 6bf0ce7 commit 23f995b

File tree

1 file changed

+36
-37
lines changed
  • packages/basehub/src/react/rich-text

1 file changed

+36
-37
lines changed

packages/basehub/src/react/rich-text/index.tsx

+36-37
Original file line numberDiff line numberDiff line change
@@ -97,77 +97,73 @@ type Node =
9797
};
9898

9999
type Handlers = {
100-
p: (props: { children?: React.ReactNode }) => React.ReactElement;
101-
b: (props: { children?: React.ReactNode }) => React.ReactElement;
102-
em: (props: { children?: React.ReactNode }) => React.ReactElement;
103-
s: (props: { children?: React.ReactNode }) => React.ReactElement;
100+
p: (props: { children: React.ReactNode }) => React.ReactElement;
101+
b: (props: { children: React.ReactNode }) => React.ReactElement;
102+
em: (props: { children: React.ReactNode }) => React.ReactElement;
103+
s: (props: { children: React.ReactNode }) => React.ReactElement;
104104
code: (props: {
105-
children?: React.ReactNode;
105+
children: React.ReactNode;
106106
isInline: boolean;
107107
}) => React.ReactElement;
108-
a: (props: {
109-
children?: React.ReactNode;
110-
href: string;
111-
}) => React.ReactElement;
112-
ol: (props: { children?: React.ReactNode }) => React.ReactElement;
108+
a: (props: { children: React.ReactNode; href: string }) => React.ReactElement;
109+
ol: (props: { children: React.ReactNode }) => React.ReactElement;
113110
ul: (props: {
114-
children?: React.ReactNode;
111+
children: React.ReactNode;
115112
isTasksList: boolean;
116113
}) => React.ReactElement;
117114
li: (
118115
props: {
119-
children?: React.ReactNode;
116+
children: React.ReactNode;
120117
} & ({ isTaskListItem: false } | { isTaskListItem: true; checked: boolean })
121118
) => React.ReactElement;
122119
h1: (props: {
123-
children?: React.ReactNode;
120+
children: React.ReactNode;
124121
id: string | null;
125122
}) => React.ReactElement;
126123
h2: (props: {
127-
children?: React.ReactNode;
124+
children: React.ReactNode;
128125
id: string | null;
129126
}) => React.ReactElement;
130127
h3: (props: {
131-
children?: React.ReactNode;
128+
children: React.ReactNode;
132129
id: string | null;
133130
}) => React.ReactElement;
134131
h4: (props: {
135-
children?: React.ReactNode;
132+
children: React.ReactNode;
136133
id: string | null;
137134
}) => React.ReactElement;
138135
h5: (props: {
139-
children?: React.ReactNode;
136+
children: React.ReactNode;
140137
id: string | null;
141138
}) => React.ReactElement;
142139
h6: (props: {
143-
children?: React.ReactNode;
140+
children: React.ReactNode;
144141
id: string | null;
145142
}) => React.ReactElement;
146143
hr: () => React.ReactElement;
147144
img: (props: {
148-
children?: React.ReactNode;
149145
src: string;
150146
alt?: string;
151147
width?: number;
152148
height?: number;
153149
}) => React.ReactElement;
154150
video: (props: {
155-
children?: React.ReactNode;
151+
children: React.ReactNode;
156152
src: string;
157153
width?: number;
158154
height?: number;
159155
}) => React.ReactElement;
160-
blockquote: (props: { children?: React.ReactNode }) => React.ReactElement;
161-
pre: (props: { children?: React.ReactNode }) => React.ReactElement;
162-
table: (props: { children?: React.ReactNode }) => React.ReactElement;
163-
tr: (props: { children?: React.ReactNode }) => React.ReactElement;
156+
blockquote: (props: { children: React.ReactNode }) => React.ReactElement;
157+
pre: (props: { children: React.ReactNode }) => React.ReactElement;
158+
table: (props: { children: React.ReactNode }) => React.ReactElement;
159+
tr: (props: { children: React.ReactNode }) => React.ReactElement;
164160
td: (props: {
165-
children?: React.ReactNode;
161+
children: React.ReactNode;
166162
colspan: number;
167163
rowspan: number;
168164
}) => React.ReactElement;
169165
th: (props: {
170-
children?: React.ReactNode;
166+
children: React.ReactNode;
171167
colspan: number;
172168
rowspan: number;
173169
}) => React.ReactElement;
@@ -202,16 +198,20 @@ export const RichText = <
202198
props: RichTextProps<CustomBlocks>
203199
) => {
204200
const value = props.children as Node[] | undefined;
205-
return value?.map((node, index) => {
206-
return (
207-
<Node
208-
node={node}
209-
key={index}
210-
components={props.components}
211-
blocks={props.blocks}
212-
/>
213-
);
214-
});
201+
return (
202+
<>
203+
{value?.map((node, index) => {
204+
return (
205+
<Node
206+
node={node}
207+
key={index}
208+
components={props.components}
209+
blocks={props.blocks}
210+
/>
211+
);
212+
})}
213+
</>
214+
);
215215
};
216216

217217
const defaultHandlers: Handlers = {
@@ -385,7 +385,6 @@ const Node = ({
385385
case "image":
386386
handler = components?.img ?? defaultHandlers.img;
387387
props = {
388-
children,
389388
src: node.attrs.src,
390389
width: node.attrs.width,
391390
height: node.attrs.height,

0 commit comments

Comments
 (0)