Skip to content

Conversation

@landsman
Copy link
Contributor

Let's turn off mouse focus at all. In JetBrains IDEs it produces unexpected UX.

Fixing issue with lost focus: #3326 (comment)

@landsman
Copy link
Contributor Author

@NicolasDorier
Copy link
Contributor

NicolasDorier commented Nov 12, 2025

The issue this fix is when a popup appear from some mouse action, the popup wouldn't be auto focused. (no issue with keyboard shortcut)

I tested this, and this work as expected. Let me check if we can't just use the jetbrain tag.


The jetbrain tag we apply only apply to a subset of popups. (those which had problems)

Some other popups (like create new branch), don't have the issues we solved in the previous commit... However it has issues related to autofocus when we open via mouse click.

This properly fix it. ACK for me.

windowrule = noinitialfocus, class:^(jetbrains-.*)$, title:^(win.*)$, floating:1

# Disable mouse focus
windowrulev2 = nofollowmouse,class:^jetbrains-.*$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use windowrule instead, and fix the formatting to be the same as above.

@cyppe
Copy link

cyppe commented Nov 12, 2025

Not related, but a lot of smart people with Jetbrins knowledge. Is there any ideas how to get the jetbrains-toolbox to scale properly in 2x too? Super small right now.

@NicolasDorier
Copy link
Contributor

NicolasDorier commented Nov 13, 2025

@cyppe, I made a video where I had a popup with scaling issue (see the Find File in the video) on #3326

If that's your issue, you just need to modify hpr/app/jetbrains.conf as from my PR.

@cyppe
Copy link

cyppe commented Nov 17, 2025

The settings you did works amazing for the editors.

I means the jetbrains-toolbox floating window/widget. Not a big deal as its mainly used for installing jetbrains editors. But still maybe someone had some idea how to get the scaling correct.

image

Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me @landsman 👏👏

@dhh dhh merged commit 42e1810 into basecamp:dev Nov 19, 2025
@landsman landsman deleted the dev branch November 19, 2025 12:56
@Syrent
Copy link

Syrent commented Nov 23, 2025

It’s a solid improvement, but it looks like tab drag-and-drop no longer works as a side effect

2025-11-23.12-42-00.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants