Skip to content

Conversation

@NicolasDorier
Copy link
Contributor

@NicolasDorier NicolasDorier commented Nov 11, 2025

This PR fix regression caused by #2899.
It also fix a scaling issues on Find in Files popups.

The config shipped with omarchy misbehaves with popups. Opening a popup
would not shift the focus automatically to it, requiring manual click on
it to start typing into it.

You can reproduce with by trying to open any popup dialog (for example
CTRL+T on Rider, or CTRL+SHIFT+F)

This config with -Dawt.toolkit.name=WLToolkit in the custom VM options
fixes all the issues I have with jetbrains.

Second, I changed the size rule from 50% 50% to >50% >50% to fix a scaling
issue that you will see on the third popup of this video (Find in Files).

screenrecording-2025-10-30_11-25-24.mp4

@AdamMusa could you try this on your setup to make sure I didn't break anything on Android Studio?

@NicolasDorier

This comment was marked as resolved.

@NicolasDorier NicolasDorier marked this pull request as draft November 11, 2025 06:20
The config shipped with omarchy misbehaves with popups. Opening a popup
would not shift the focus automatically to it, requiring manual click on
it to start typing into it.

You can reproduce with by trying to open any popup dialog (for example
CTRL+T on Rider, or CTRL+SHIFT+F)

This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options
fixes all the issues I have with jetbrains. I am also making a dedicated
workspace which float all windows just for jetbrains.
@NicolasDorier NicolasDorier marked this pull request as ready for review November 11, 2025 08:11
@NicolasDorier
Copy link
Contributor Author

NicolasDorier commented Nov 11, 2025

Ok this PR is ready, it solves the focus issue and also the scaling issue for the Find in Files popup.
I've filed a bug report in hyprland, as it seems I can't use tag:jb for size rule.

@jorgemanrubia jorgemanrubia self-assigned this Nov 11, 2025
@landsman
Copy link
Contributor

landsman commented Nov 11, 2025

Tested in Idea Ultimate and it seems to be working fine. Focus is now fixed. Thanks!

Related discussion: #100

Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me too with RubyMine.

I was already using the tweaks described here, but removing those and adding this and things continue working fine.

This config with -Dawt.toolkit.name=WLToolkit in the custom VM options
fixes all the issues I have with jetbrains.

I think I had originally added this but I am not using it now and things work ok. Is it possible Jetbrains fixed it upstream and now it is not needed?

UPDATE: It is actually needed, or popup dialogs will get auto-closed when moving the mouse outside!

@AdamMusa
Copy link
Contributor

Ok this PR is ready, it solves the focus issue and also the scaling issue for the Find in Files popup. I've filed a bug report in hyprland, as it seems I can't use tag:jb for size rule.

Android Studio is working fine on my end, and the popup now gets focus. Great addition, @NicolasDorier!

@landsman
Copy link
Contributor

Only weird edge-case I was able to found was this behavior on vertical FHD monitor.

screenshot-2025-11-11_12-54-26

@landsman
Copy link
Contributor

landsman commented Nov 11, 2025

Found focus issues.

Steps to reproduce:

  1. Open some file where you can write
  2. Click to change git branch -> new branch
  3. Try to write something, name of the branch
  4. Focus is lost, moved back to the file under the modal window

It does not have the problem when I do this via shortcut: CTRL+ALT+N. Probably because of mouse movement is not present there.

Can we somehow disable changing focus by mouse hover in general? Click makes sense more there.

@coendewit
Copy link

You beat me to it, so thanks so much @NicolasDorier! Can confirm this is working smoothly on Rider!

@dhh dhh changed the base branch from master to dev November 11, 2025 14:54
@dhh dhh merged commit bea5791 into basecamp:dev Nov 11, 2025
@NicolasDorier
Copy link
Contributor Author

@landsman Input::follow_mouse.
This disable the auto focus of the mouse. If you do this, then no more issue.

@NicolasDorier NicolasDorier deleted the jetbrain-fix branch November 11, 2025 14:54
@landsman
Copy link
Contributor

landsman commented Nov 11, 2025

@landsman Input::follow_mouse. This disable the auto focus of the mouse. If you do this, then no more issue.

Thanks for the suggestion - it works perfectly now.

I added:

windowrulev2 = nofollowmouse,class:^jetbrains-.*$

@mmillis1
Copy link

I know this has been merged but just wanted to say I tested this on phpstorm (installed via toolbox) and I believe it has fixed things :)

@DenysFlnk
Copy link

DenysFlnk commented Nov 12, 2025

I know this has been merged but just wanted to say I tested this on phpstorm (installed via toolbox) and I believe it has fixed things :)

How did you install and use toolbox? It is not freezes on start up? @mmillis1

@siancu
Copy link

siancu commented Nov 12, 2025

I know this has been merged but just wanted to say I tested this on phpstorm (installed via toolbox) and I believe it has fixed things :)

How did you install and use toolbox? It is not freezes on start up? @mmillis1

I personally installed jetbrains-toolbox from AUR. It starts without any issues, the only problem is that once I open the "widget" where you can install the apps, I can't close it anymore. I tried pressing Esc or clicking outside the widget, but it just stays on. So for now I install the apps I need and when it's done, I just exit the toolbox.

@siancu
Copy link

siancu commented Nov 12, 2025

@landsman Input::follow_mouse. This disable the auto focus of the mouse. If you do this, then no more issue.

Thanks for the suggestion - it works perfectly now.

I added:

windowrulev2 = nofollowmouse,class:^jetbrains-.*$

This doesn't seem to be in the merged code, did you add it afterwards?

@luciano-fiandesio
Copy link

Leaving a note here for others: this commit doesn't work by itself (on Omarchy 3.1.7). To make it work correctly, I had to comment out all the hypr rules defined in ~/.local/share/omarchy/default/hypr/apps/jetbrains.conf.

patroza pushed a commit to patroza/omarchy that referenced this pull request Nov 15, 2025
…mp#3326)

* Fix: Jetbrains popup dialog would not get focus automatically

The config shipped with omarchy misbehaves with popups. Opening a popup
would not shift the focus automatically to it, requiring manual click on
it to start typing into it.

You can reproduce with by trying to open any popup dialog (for example
CTRL+T on Rider, or CTRL+SHIFT+F)

This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options
fixes all the issues I have with jetbrains. I am also making a dedicated
workspace which float all windows just for jetbrains.

* Use existing formatting conventions

* More tweaks

---------

Co-authored-by: David Heinemeier Hansson <[email protected]>
patroza pushed a commit to patroza/omarchy that referenced this pull request Nov 18, 2025
…mp#3326)

* Fix: Jetbrains popup dialog would not get focus automatically

The config shipped with omarchy misbehaves with popups. Opening a popup
would not shift the focus automatically to it, requiring manual click on
it to start typing into it.

You can reproduce with by trying to open any popup dialog (for example
CTRL+T on Rider, or CTRL+SHIFT+F)

This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options
fixes all the issues I have with jetbrains. I am also making a dedicated
workspace which float all windows just for jetbrains.

* Use existing formatting conventions

* More tweaks

---------

Co-authored-by: David Heinemeier Hansson <[email protected]>
@NicolasDorier
Copy link
Contributor Author

Leaving a note here for others: this commit doesn't work by itself (on Omarchy 3.1.7). To make it work correctly, I had to comment out all the hypr rules defined in ~/.local/share/omarchy/default/hypr/apps/jetbrains.conf.

Yes, this PR is actually editing this file. (replacing the old one that was giving issues)

@NicolasDorier
Copy link
Contributor Author

@landsman Input::follow_mouse. This disable the auto focus of the mouse. If you do this, then no more issue.

Thanks for the suggestion - it works perfectly now.
I added:

windowrulev2 = nofollowmouse,class:^jetbrains-.*$

This doesn't seem to be in the merged code, did you add it afterwards?

#3336

andrew-a-hale pushed a commit to andrew-a-hale/omarchy that referenced this pull request Nov 29, 2025
…mp#3326)

* Fix: Jetbrains popup dialog would not get focus automatically

The config shipped with omarchy misbehaves with popups. Opening a popup
would not shift the focus automatically to it, requiring manual click on
it to start typing into it.

You can reproduce with by trying to open any popup dialog (for example
CTRL+T on Rider, or CTRL+SHIFT+F)

This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options
fixes all the issues I have with jetbrains. I am also making a dedicated
workspace which float all windows just for jetbrains.

* Use existing formatting conventions

* More tweaks

---------

Co-authored-by: David Heinemeier Hansson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants