-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix: Jetbrains popup dialog would not get focus automatically #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
The config shipped with omarchy misbehaves with popups. Opening a popup would not shift the focus automatically to it, requiring manual click on it to start typing into it. You can reproduce with by trying to open any popup dialog (for example CTRL+T on Rider, or CTRL+SHIFT+F) This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options fixes all the issues I have with jetbrains. I am also making a dedicated workspace which float all windows just for jetbrains.
c9a7d07 to
0583e84
Compare
|
Ok this PR is ready, it solves the focus issue and also the scaling issue for the |
|
Tested in Idea Ultimate and it seems to be working fine. Focus is now fixed. Thanks! Related discussion: #100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine for me too with RubyMine.
I was already using the tweaks described here, but removing those and adding this and things continue working fine.
This config with -Dawt.toolkit.name=WLToolkit in the custom VM options
fixes all the issues I have with jetbrains.
I think I had originally added this but I am not using it now and things work ok. Is it possible Jetbrains fixed it upstream and now it is not needed?
UPDATE: It is actually needed, or popup dialogs will get auto-closed when moving the mouse outside!
Android Studio is working fine on my end, and the popup now gets focus. Great addition, @NicolasDorier! |
|
Found focus issues. Steps to reproduce:
It does not have the problem when I do this via shortcut: Can we somehow disable changing focus by mouse hover in general? Click makes sense more there. |
|
You beat me to it, so thanks so much @NicolasDorier! Can confirm this is working smoothly on Rider! |
|
@landsman Input::follow_mouse. |
Thanks for the suggestion - it works perfectly now. I added: |
|
I know this has been merged but just wanted to say I tested this on phpstorm (installed via toolbox) and I believe it has fixed things :) |
How did you install and use toolbox? It is not freezes on start up? @mmillis1 |
I personally installed jetbrains-toolbox from AUR. It starts without any issues, the only problem is that once I open the "widget" where you can install the apps, I can't close it anymore. I tried pressing Esc or clicking outside the widget, but it just stays on. So for now I install the apps I need and when it's done, I just exit the toolbox. |
This doesn't seem to be in the merged code, did you add it afterwards? |
|
Leaving a note here for others: this commit doesn't work by itself (on Omarchy 3.1.7). To make it work correctly, I had to comment out all the hypr rules defined in |
…mp#3326) * Fix: Jetbrains popup dialog would not get focus automatically The config shipped with omarchy misbehaves with popups. Opening a popup would not shift the focus automatically to it, requiring manual click on it to start typing into it. You can reproduce with by trying to open any popup dialog (for example CTRL+T on Rider, or CTRL+SHIFT+F) This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options fixes all the issues I have with jetbrains. I am also making a dedicated workspace which float all windows just for jetbrains. * Use existing formatting conventions * More tweaks --------- Co-authored-by: David Heinemeier Hansson <[email protected]>
…mp#3326) * Fix: Jetbrains popup dialog would not get focus automatically The config shipped with omarchy misbehaves with popups. Opening a popup would not shift the focus automatically to it, requiring manual click on it to start typing into it. You can reproduce with by trying to open any popup dialog (for example CTRL+T on Rider, or CTRL+SHIFT+F) This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options fixes all the issues I have with jetbrains. I am also making a dedicated workspace which float all windows just for jetbrains. * Use existing formatting conventions * More tweaks --------- Co-authored-by: David Heinemeier Hansson <[email protected]>
Yes, this PR is actually editing this file. (replacing the old one that was giving issues) |
|
…mp#3326) * Fix: Jetbrains popup dialog would not get focus automatically The config shipped with omarchy misbehaves with popups. Opening a popup would not shift the focus automatically to it, requiring manual click on it to start typing into it. You can reproduce with by trying to open any popup dialog (for example CTRL+T on Rider, or CTRL+SHIFT+F) This config with `-Dawt.toolkit.name=WLToolkit` in the custom VM options fixes all the issues I have with jetbrains. I am also making a dedicated workspace which float all windows just for jetbrains. * Use existing formatting conventions * More tweaks --------- Co-authored-by: David Heinemeier Hansson <[email protected]>

This PR fix regression caused by #2899.
It also fix a scaling issues on
Find in Filespopups.The config shipped with omarchy misbehaves with popups. Opening a popup
would not shift the focus automatically to it, requiring manual click on
it to start typing into it.
You can reproduce with by trying to open any popup dialog (for example
CTRL+T on Rider, or CTRL+SHIFT+F)
This config with
-Dawt.toolkit.name=WLToolkitin the custom VM optionsfixes all the issues I have with jetbrains.
Second, I changed the size rule from
50% 50%to>50% >50%to fix a scalingissue that you will see on the third popup of this video (Find in Files).
screenrecording-2025-10-30_11-25-24.mp4
@AdamMusa could you try this on your setup to make sure I didn't break anything on Android Studio?