From 5e240dfb6a494422cb42e03f6526ed92048f264b Mon Sep 17 00:00:00 2001 From: Lewis Buckley Date: Tue, 30 Apr 2024 09:39:19 +0100 Subject: [PATCH 1/3] Update GitHub Actions flow with Ruby 3 --- .github/workflows/ruby.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index b8081ed..4f81ddb 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -26,7 +26,7 @@ jobs: - name: Setup Ruby and install gems uses: ruby/setup-ruby@v1 with: - ruby-version: 2.7.2 + ruby-version: 3.3.1 bundler-cache: true - name: Run rubocop run: | @@ -39,7 +39,7 @@ jobs: CI: true strategy: matrix: - ruby-version: ['3.0'] + ruby-version: ['3.0', '3.3'] services: redis: image: redis:4.0-alpine From 5dc61261110df24e215fb2265de9c67f54d838f4 Mon Sep 17 00:00:00 2001 From: Lewis Buckley Date: Tue, 30 Apr 2024 09:41:04 +0100 Subject: [PATCH 2/3] Drop trailing comma --- test/dummy/config/application.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/dummy/config/application.rb b/test/dummy/config/application.rb index 6730171..8694115 100644 --- a/test/dummy/config/application.rb +++ b/test/dummy/config/application.rb @@ -18,7 +18,7 @@ class Application < Rails::Application config.mission_control.web.redis = Redis.new(url: "redis://localhost:6379/15") config.mission_control.web.administered_applications = [ { name: "Dummy App", redis: Redis.new(url: "redis://localhost:6379/15") }, - { name: "Another Dummy App", redis: Redis.new(url: "redis://localhost:6379/15") }, + { name: "Another Dummy App", redis: Redis.new(url: "redis://localhost:6379/15") } ] # Configuration for the application, engines, and railties goes here. From 5a54fdf227efc7b9ff5066f4f525b79baf968c41 Mon Sep 17 00:00:00 2001 From: Lewis Buckley Date: Tue, 30 Apr 2024 09:41:45 +0100 Subject: [PATCH 3/3] Loosen performance standard --- .../web/request_filter_middleware_performance_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/performance/mission_control/web/request_filter_middleware_performance_test.rb b/test/performance/mission_control/web/request_filter_middleware_performance_test.rb index 0563156..27af97d 100644 --- a/test/performance/mission_control/web/request_filter_middleware_performance_test.rb +++ b/test/performance/mission_control/web/request_filter_middleware_performance_test.rb @@ -11,7 +11,7 @@ class RequestFilterMiddlewarePerformanceTest < ActionDispatch::IntegrationTest assert_equal 200, status } - assert_slower_by_at_most 1.23, baseline: baseline do + assert_slower_by_at_most 1.3, baseline: baseline do MissionControl::Web.configuration.middleware_enabled = true get posts_path