Feature Request: Add internationalization (i18n) support and Vietnamese localization #2074
mydalat
started this conversation in
Ideas and Issue Triage
Replies: 2 comments
-
|
Please see #1970 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
@mydalat, in this thread @jzimdars was open to look at potential pull requests to evaluate if they should accept the functionality. #1970 (comment) Could you try to open for your "full localization proposal" (I'd personally start infrastructure first, to narrow down the scope of the PR)? I'm willing to contribute to that PR too (and, later, create a Catalan translation) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
I would like to contribute Vietnamese (vi) localization to Fizzy. Before submitting a PR, I wanted to discuss the best approach with the maintainers.
Background
I've been using Fizzy for my team in Vietnam and have created a complete Vietnamese translation. However, since Fizzy currently has hardcoded English strings in views, I had to:
rails-i18ngem for Rails i18n supportconfig/locales/vi.ymlwith Vietnamese translationst()helper instead of hardcoded stringsProposal
I see two possible approaches:
Option A: Full i18n Implementation (Recommended)
t()helperen.ymlas the default localevi.ymlfor VietnamesePros: Enables future translations, follows Rails conventions
Cons: Large PR, many file changes
Option B: Vietnamese-only Fork
Pros: No impact on main repo
Cons: Community doesn't benefit, harder to sync updates
What I've Already Done
I have a working implementation that includes:
500+ translated strings covering:
Views migrated to use
t()helper (~50 files)Questions for Maintainers
en.ymlfile extracting current English strings?Sample of vi.yml
Beta Was this translation helpful? Give feedback.
All reactions