Skip to content

Commit 38f7292

Browse files
committed
Fix devservices with DB backup
1 parent 17aebe1 commit 38f7292

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

horreum-backend/src/main/resources/application.properties

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ quarkus.keycloak.admin-client.grant-type=CLIENT_CREDENTIALS
100100
%dev.quarkus.keycloak.admin-client.client-id=admin-cli
101101
%dev.quarkus.keycloak.admin-client.realm=master
102102
%dev.quarkus.keycloak.admin-client.grant-type=PASSWORD
103-
%dev.quarkus.keycloak.admin-client.username=admin
104-
%dev.quarkus.keycloak.admin-client.password=secret
103+
%dev.quarkus.keycloak.admin-client.username=${horreum.dev-services.keycloak.admin-username}
104+
%dev.quarkus.keycloak.admin-client.password=${horreum.dev-services.keycloak.admin-password}
105105

106106
# Secret used to sign database rows
107107
horreum.db.secret=secret

infra/horreum-infra-common/src/main/java/io/hyperfoil/tools/horreum/infra/common/HorreumResources.java

+12-8
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,20 @@ public static Map<String, String> startContainers(Map<String, String> initArgs)
166166
String keycloakAdminUser = initArgs.get(HORREUM_DEV_KEYCLOAK_ADMIN_USERNAME);
167167
String keycloakAdminPassword = initArgs.get(HORREUM_DEV_KEYCLOAK_ADMIN_PASSWORD);
168168

169-
keycloak = KeycloakBuilder.builder()
170-
.serverUrl(keycloakEnv.get("keycloak.host"))
171-
.realm(KEYCLOAK_REALM)
172-
.username(keycloakAdminUser)
173-
.password(keycloakAdminPassword)
174-
.clientId("admin-cli")
175-
.resteasyClient(((ResteasyClientBuilder) ClientBuilder.newBuilder()).disableTrustManager().build())
176-
.build();
169+
envVariables.put(HORREUM_DEV_KEYCLOAK_ADMIN_USERNAME, keycloakAdminUser);
170+
envVariables.put(HORREUM_DEV_KEYCLOAK_ADMIN_PASSWORD, keycloakAdminPassword);
177171

178172
if (!initArgs.containsKey(HORREUM_DEV_POSTGRES_BACKUP)) {
173+
174+
keycloak = KeycloakBuilder.builder()
175+
.serverUrl(keycloakEnv.get("keycloak.host"))
176+
.realm(KEYCLOAK_REALM)
177+
.username(keycloakAdminUser)
178+
.password(keycloakAdminPassword)
179+
.clientId("admin-cli")
180+
.resteasyClient(((ResteasyClientBuilder) ClientBuilder.newBuilder()).disableTrustManager().build())
181+
.build();
182+
179183
// Not using a backup db, so need to create the dummy roles
180184

181185
// Obtain client secrets for Horreum

infra/horreum-infra-common/src/main/java/io/hyperfoil/tools/horreum/infra/common/resources/KeycloakResource.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ public void init(Map<String, String> initArgs) {
3939
throw new RuntimeException("Arguments did not contain Keycloak image");
4040
}
4141

42-
final String JDBC_URL = initArgs.get("quarkus.datasource.jdbc.url.internal");
43-
final String DB_PORT = initArgs.get("postgres.container.port");
44-
4542
final String KEYCLOAK_IMAGE = initArgs.get(HORREUM_DEV_KEYCLOAK_IMAGE);
4643

4744
networkAlias = initArgs.get(HORREUM_DEV_KEYCLOAK_NETWORK_ALIAS);
@@ -73,7 +70,7 @@ public void init(Map<String, String> initArgs) {
7370
.env("KC_HTTP_ENABLED", "true")
7471
.env("KC_HOSTNAME_STRICT", "false")
7572
.env("DB_DATABASE", "keycloak")
76-
.env("KC_DB_URL", JDBC_URL)
73+
.env("KC_DB_URL", initArgs.get("quarkus.datasource.jdbc.url.internal"))
7774
.run("/opt/keycloak/bin/kc.sh build")
7875
.entryPoint("/opt/keycloak/bin/kc.sh ${KEYCLOAK_COMMAND:-start-dev} --import-realm $EXTRA_OPTIONS")
7976
.build()).withFileFromFile("/tmp/keycloak-horreum.json", tempKeycloakRealmFile);
@@ -100,7 +97,7 @@ public void init(Map<String, String> initArgs) {
10097
.withEnv("KC_DB_URL_HOST", "")
10198
.withEnv("KC_HOSTNAME_STRICT", "false")
10299
.withEnv("KC_HOSTNAME", "localhost")
103-
.withEnv("KC_DB_URL", "jdbc:postgresql://172.17.0.1:" + DB_PORT + "/keycloak")
100+
.withEnv("KC_DB_URL", "jdbc:postgresql://" + initArgs.get(HORREUM_DEV_POSTGRES_NETWORK_ALIAS) + ":5432/keycloak")
104101
.withCommand("-Dquarkus.http.http2=false", "start-dev");
105102
}
106103

0 commit comments

Comments
 (0)