Skip to content

Commit 2030e58

Browse files
committed
Fix devservices with DB backup
1 parent 17aebe1 commit 2030e58

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

horreum-backend/src/main/resources/application.properties

-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ quarkus.keycloak.admin-client.grant-type=CLIENT_CREDENTIALS
100100
%dev.quarkus.keycloak.admin-client.client-id=admin-cli
101101
%dev.quarkus.keycloak.admin-client.realm=master
102102
%dev.quarkus.keycloak.admin-client.grant-type=PASSWORD
103-
%dev.quarkus.keycloak.admin-client.username=admin
104-
%dev.quarkus.keycloak.admin-client.password=secret
105103

106104
# Secret used to sign database rows
107105
horreum.db.secret=secret

infra/horreum-dev-services/deployment/src/main/java/io/hyperfoil/tools/horreum/dev/services/deployment/HorreumDevServicesProcessor.java

+2
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ public void startHorreumContainers(
126126
keycloakConfig.put("horreum.keycloak.url", keycloakURL);
127127
keycloakConfig.put("quarkus.oidc.auth-server-url", keycloakURL + "/realms/horreum");
128128
keycloakConfig.put("quarkus.oidc.credentials.secret", envvars.get("quarkus.oidc.credentials.secret"));
129+
keycloakConfig.put("quarkus.keycloak.admin-client.username", horreumBuildTimeConfig.keycloak.adminUsername);
130+
keycloakConfig.put("quarkus.keycloak.admin-client.password", horreumBuildTimeConfig.keycloak.adminPassword);
129131
if (envvars.containsKey("quarkus.oidc.tls.trust-store-file")) {
130132
keycloakConfig.put("quarkus.oidc.tls.trust-store-file", envvars.get("quarkus.oidc.tls.trust-store-file"));
131133
keycloakConfig.put("quarkus.oidc.tls.verification", "required"); // "certificate-validation" validates the certificate chain, but not the hostname. could also be "none" and disable TLS verification altogether

infra/horreum-infra-common/src/main/java/io/hyperfoil/tools/horreum/infra/common/HorreumResources.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,11 @@ public static Map<String, String> startContainers(Map<String, String> initArgs)
163163
envVariables.put("quarkus.oidc.auth-server-url", keycloakEnv.get("keycloak.host").concat("/realms/").concat(HORREUM_REALM));
164164
envVariables.putAll(oidcTruststoreProperties(initArgs));
165165

166-
String keycloakAdminUser = initArgs.get(HORREUM_DEV_KEYCLOAK_ADMIN_USERNAME);
167-
String keycloakAdminPassword = initArgs.get(HORREUM_DEV_KEYCLOAK_ADMIN_PASSWORD);
168-
169166
keycloak = KeycloakBuilder.builder()
170167
.serverUrl(keycloakEnv.get("keycloak.host"))
171168
.realm(KEYCLOAK_REALM)
172-
.username(keycloakAdminUser)
173-
.password(keycloakAdminPassword)
169+
.username(initArgs.get(HORREUM_DEV_KEYCLOAK_ADMIN_USERNAME))
170+
.password(initArgs.get(HORREUM_DEV_KEYCLOAK_ADMIN_PASSWORD))
174171
.clientId("admin-cli")
175172
.resteasyClient(((ResteasyClientBuilder) ClientBuilder.newBuilder()).disableTrustManager().build())
176173
.build();

infra/horreum-infra-common/src/main/java/io/hyperfoil/tools/horreum/infra/common/resources/KeycloakResource.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ public void init(Map<String, String> initArgs) {
3939
throw new RuntimeException("Arguments did not contain Keycloak image");
4040
}
4141

42-
final String JDBC_URL = initArgs.get("quarkus.datasource.jdbc.url.internal");
43-
final String DB_PORT = initArgs.get("postgres.container.port");
44-
4542
final String KEYCLOAK_IMAGE = initArgs.get(HORREUM_DEV_KEYCLOAK_IMAGE);
4643

4744
networkAlias = initArgs.get(HORREUM_DEV_KEYCLOAK_NETWORK_ALIAS);
@@ -73,7 +70,7 @@ public void init(Map<String, String> initArgs) {
7370
.env("KC_HTTP_ENABLED", "true")
7471
.env("KC_HOSTNAME_STRICT", "false")
7572
.env("DB_DATABASE", "keycloak")
76-
.env("KC_DB_URL", JDBC_URL)
73+
.env("KC_DB_URL", initArgs.get("quarkus.datasource.jdbc.url.internal"))
7774
.run("/opt/keycloak/bin/kc.sh build")
7875
.entryPoint("/opt/keycloak/bin/kc.sh ${KEYCLOAK_COMMAND:-start-dev} --import-realm $EXTRA_OPTIONS")
7976
.build()).withFileFromFile("/tmp/keycloak-horreum.json", tempKeycloakRealmFile);
@@ -100,7 +97,7 @@ public void init(Map<String, String> initArgs) {
10097
.withEnv("KC_DB_URL_HOST", "")
10198
.withEnv("KC_HOSTNAME_STRICT", "false")
10299
.withEnv("KC_HOSTNAME", "localhost")
103-
.withEnv("KC_DB_URL", "jdbc:postgresql://172.17.0.1:" + DB_PORT + "/keycloak")
100+
.withEnv("KC_DB_URL", "jdbc:postgresql://" + initArgs.get(HORREUM_DEV_POSTGRES_NETWORK_ALIAS) + ":5432/keycloak")
104101
.withCommand("-Dquarkus.http.http2=false", "start-dev");
105102
}
106103

0 commit comments

Comments
 (0)