Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the OpenAPI Tool sanitize Sub Command Name - bal openapi sanitize #7484

Closed
SachinAkash01 opened this issue Jan 6, 2025 · 2 comments · Fixed by ballerina-platform/openapi-tools#1809

Comments

@SachinAkash01
Copy link
Member

Description

The following are few suggestions:

  1. bal openapi conform - Implies ensuring the contract conforms to Ballerina-friendly standards
  2. bal openapi adapt - Implies adapting the OpenAPI contract to fit Ballerina's requirements
  3. bal openapi align - Emphasises aligning the OpenAPI contract with Ballerina's best practices
  4. bal openapi transform - Indicates transforming the OpenAPI contract to be compatible with Ballerina

Version

No response

@lnash94
Copy link
Member

lnash94 commented Jan 6, 2025

How about using bal openapi adapt as a subcommand? Since our primary goal is to modify the specification so that it aligns with Ballerina.
I’d reserve “transform” for cases where we’re converting between formats (for example, OpenAPI v3 to OpenAPI v2, or OpenAPI to a API Blueprint model, RAML).

@SachinAkash01
Copy link
Member Author

Meeting : 06/01/2025

Attendees: @shafreenAnfar @daneshk @lnash94 @TharmiganK @SachinAkash01

Notes:

  • As discussed, we have decided to replace the bal openapi sanitize sub-command with bal openapi align, as the term align better reflects the purpose of this command.
  • The bal openapi align command will take an OpenAPI specification as input, modify it to align with Ballerina's best practices (eg: adhering to naming conventions), and output a modified OpenAPI specification.
  • The output file currently named as sanitized_openapi.json will be renamed to aligned_ballerina_openapi.json to maintain the consistency within the new sub-command and its intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants