Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to get the arenastring.patch for lower protobuf version? #81

Open
welsonzhang opened this issue Jan 13, 2025 · 2 comments
Open

how to get the arenastring.patch for lower protobuf version? #81

welsonzhang opened this issue Jan 13, 2025 · 2 comments

Comments

@welsonzhang
Copy link

Is it possible to merge the arenastring.patch to lower protobuf version, example for 21.7?Is there anything I need to pay attention to?

@oathdruid
Copy link
Collaborator

Possible but need do a careful merge diff check.

  • the core new file arenastring_impl.h is same for each version
  • check TaggedPtr in arenastring.h, some old version have different implementation, that will make it hard to merge.
  • most ugly part is repeated_ptr_field.h, need to be carefully diffed line by line

in fact, we do have a 21.12 version of this patch internal, maybe you could ask @eesly if it can be exported to open source repo

@welsonzhang
Copy link
Author

Thanks a lot. I have found it in internal repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants