Merge pull request #34 from b4b4r07/fix/http-url-bug

Fix `http.Installed()` behavior

Author: b4b4r07

pkg/config/config.go

@@ -81,6 +81,7 @@ func parse(cfg Config) []Package {
 		pkgs = append(pkgs, pkg)
 	}
 	for _, pkg := range cfg.HTTP {
+		pkg.ParseURL()
 		pkgs = append(pkgs, pkg)
 	}
 

pkg/config/http.go

@@ -75,6 +75,8 @@ func (c HTTP) call(ctx context.Context) error {
 
 	os.MkdirAll(c.GetHome(), os.ModePerm)
 	dest := filepath.Join(c.GetHome(), filepath.Base(c.URL))
+
+	log.Printf("[DEBUG] http: %s: copying %q to %q", c.GetName(), c.URL, dest)
 	file, err := os.Create(dest)
 	if err != nil {
 		return err
@@ -102,17 +104,6 @@ func (c HTTP) Install(ctx context.Context, status chan<- Status) error {
 		// Go installing step!
 	}
 
-	url, err := templates.New(data.New(data.WithPackage(c))).
-		Replace(c.Templates.Replacements).
-		Apply(c.URL)
-	if err != nil {
-		return err
-	}
-	if url != c.URL {
-		log.Printf("[DEBUG] %s: templating url %s", c.GetName(), url)
-		c.URL = url
-	}
-
 	ctx, cancel := context.WithCancel(ctx)
 	defer cancel()
 
@@ -252,3 +243,18 @@ func (c HTTP) GetDependsOn() []string {
 func (c HTTP) GetResource() state.Resource {
 	return getResource(c)
 }
+
+func (c *HTTP) ParseURL() {
+	templated, err := templates.New(data.New(data.WithPackage(c))).
+		Replace(c.Templates.Replacements).
+		Apply(c.URL)
+	if err != nil {
+		log.Printf("[ERROR] %s: failed to parse URL", c.GetName())
+		return
+	}
+	if templated != c.URL {
+		log.Printf("[TRACE] %s: templating URL %q to %q", c.GetName(), c.URL, templated)
+		c.URL = templated
+	}
+	return
+}