Closed
Description
Describe the bug
As per current documentation: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/credproviders.html the aws-rust-sdk should fully support Amazon ECS and Amazon EKS container credentials providers.
I spot a bug that doesn't allow me to pass query parameters to a http request.
A bug has been introduced in: smithy-lang/smithy-rs#2997
On line aws/rust-runtime/aws-config/src/ecs.rs#169 a new variable has been introduced
let path = uri.path().to_string();
and on line aws/rust-runtime/aws-config/src/ecs.rs#186 we now pass it to http builder instead of the uri variable.
.build("EcsContainer", &endpoint, path);
As uri.path() method returns only a path info we've lost all query info.
A simplest way to fix this is to call a path_and_query() method on uri to populate query parameters to the path variable, kinda:
% git diff
diff --git a/src/ecs.rs b/src/ecs.rs
index fc7e8ad..1dc2928 100644
--- a/src/ecs.rs
+++ b/src/ecs.rs
@@ -191,7 +191,7 @@ impl Provider {
Err(EcsConfigurationError::NotConfigured) => return Provider::NotConfigured,
Err(err) => return Provider::InvalidConfiguration(err),
};
- let path = uri.path().to_string();
+ let path = uri.path_and_query().unwrap().to_string();
let endpoint = {
let mut parts = uri.into_parts();
parts.path_and_query = Some(PathAndQuery::from_static("/"));
Regression Issue
- Select this option if this issue appears to be a regression.
Expected Behavior
- expected: to pass query parameters to cred's http request:
% sudo ncat --listen 80
GET /my-credentials/?applicationName=test2024 HTTP/1.1
accept: application/json
host: 169.254.170.2
Current Behavior
observed: passed only uri
% sudo ncat --listen 80
GET /my-credentials/ HTTP/1.1
accept: application/json
host: 169.254.170.2
Reproduction Steps
- code snippet
use aws_config::BehaviorVersion;
use aws_config::ecs::EcsCredentialsProvider;
use aws_sdk_cloudwatch::Client;
#[tokio::main]
async fn main() {
std::env::set_var("RUST_LOG", "debug");
std::env::set_var("AWS_CONTAINER_CREDENTIALS_RELATIVE_URI", "/my-credentials/?applicationName=test2024");
let provider: EcsCredentialsProvider = EcsCredentialsProvider::builder().build();
let config = aws_config::defaults(BehaviorVersion::latest())
.region("eu-west-1")
.credentials_provider(provider)
.load()
.await;
let client = Client::new(&config);
let req = client.list_dashboards();
let resp = req.send().await;
println!("resp: {:?}", resp);
}
- add ip_addr to localhost
% sudo ip addr add 169.254.170.2 dev lo
- run
netcatto check http requests
% sudo ncat --listen 80
- run code snippet
./target/debug/hello_world
Possible Solution
No response
Additional Information/Context
No response
Version
% cargo tree | grep aws-
├── aws-config v1.5.10 (/home/romangoward/aws-config)
│ ├── aws-credential-types v1.2.1
│ │ ├── aws-smithy-async v1.2.2
│ │ ├── aws-smithy-runtime-api v1.7.3
│ │ │ ├── aws-smithy-async v1.2.2 (*)
│ │ │ ├── aws-smithy-types v1.2.10
│ │ ├── aws-smithy-types v1.2.10 (*)
│ ├── aws-runtime v1.5.1
│ │ ├── aws-credential-types v1.2.1 (*)
│ │ ├── aws-sigv4 v1.2.6
│ │ │ ├── aws-credential-types v1.2.1 (*)
│ │ │ ├── aws-smithy-http v0.60.11
│ │ │ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ │ │ ├── aws-smithy-types v1.2.10 (*)
│ │ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-smithy-async v1.2.2 (*)
│ │ ├── aws-smithy-http v0.60.11 (*)
│ │ ├── aws-smithy-runtime v1.7.5
│ │ │ ├── aws-smithy-async v1.2.2 (*)
│ │ │ ├── aws-smithy-http v0.60.11 (*)
│ │ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-types v1.3.3
│ │ │ ├── aws-credential-types v1.2.1 (*)
│ │ │ ├── aws-smithy-async v1.2.2 (*)
│ │ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ │ ├── aws-smithy-types v1.2.10 (*)
│ ├── aws-sdk-sso v1.51.0
│ │ ├── aws-credential-types v1.2.1 (*)
│ │ ├── aws-runtime v1.5.1 (*)
│ │ ├── aws-smithy-async v1.2.2 (*)
│ │ ├── aws-smithy-http v0.60.11 (*)
│ │ ├── aws-smithy-json v0.61.1
│ │ │ └── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-smithy-runtime v1.7.5 (*)
│ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-types v1.3.3 (*)
│ ├── aws-sdk-ssooidc v1.52.0
│ │ ├── aws-credential-types v1.2.1 (*)
│ │ ├── aws-runtime v1.5.1 (*)
│ │ ├── aws-smithy-async v1.2.2 (*)
│ │ ├── aws-smithy-http v0.60.11 (*)
│ │ ├── aws-smithy-json v0.61.1 (*)
│ │ ├── aws-smithy-runtime v1.7.5 (*)
│ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-types v1.3.3 (*)
│ ├── aws-sdk-sts v1.52.0
│ │ ├── aws-credential-types v1.2.1 (*)
│ │ ├── aws-runtime v1.5.1 (*)
│ │ ├── aws-smithy-async v1.2.2 (*)
│ │ ├── aws-smithy-http v0.60.11 (*)
│ │ ├── aws-smithy-json v0.61.1 (*)
│ │ ├── aws-smithy-query v0.60.7
│ │ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-smithy-runtime v1.7.5 (*)
│ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ ├── aws-smithy-types v1.2.10 (*)
│ │ ├── aws-smithy-xml v0.60.9
│ │ ├── aws-types v1.3.3 (*)
│ ├── aws-smithy-async v1.2.2 (*)
│ ├── aws-smithy-http v0.60.11 (*)
│ ├── aws-smithy-json v0.60.7
│ │ └── aws-smithy-types v1.2.10 (*)
│ ├── aws-smithy-runtime v1.7.5 (*)
│ ├── aws-smithy-runtime-api v1.7.3 (*)
│ ├── aws-smithy-types v1.2.10 (*)
│ ├── aws-types v1.3.3 (*)
├── aws-sdk-cloudwatch v1.57.0
│ ├── aws-credential-types v1.2.1 (*)
│ ├── aws-runtime v1.5.1 (*)
│ ├── aws-smithy-async v1.2.2 (*)
│ ├── aws-smithy-compression v0.0.2
│ │ ├── aws-smithy-runtime-api v1.7.3 (*)
│ │ ├── aws-smithy-types v1.2.10 (*)
│ ├── aws-smithy-http v0.60.11 (*)
│ ├── aws-smithy-json v0.61.1 (*)
│ ├── aws-smithy-query v0.60.7 (*)
│ ├── aws-smithy-runtime v1.7.5 (*)
│ ├── aws-smithy-runtime-api v1.7.3 (*)
│ ├── aws-smithy-types v1.2.10 (*)
│ ├── aws-smithy-xml v0.60.9 (*)
│ ├── aws-types v1.3.3 (*)
├── aws-sdk-sts v1.52.0 (*)
Environment details (OS name and version, etc.)
Amazon Linux 2 @ 5.10.230-202.885.amzn2int.x86_64
Logs
No response