Changed error handling codes according to latest specs clarified in #23

Author: sapessi

lambda-runtime-client/src/client.rs

@@ -1,4 +1,4 @@
-use error::{ApiError, ErrorResponse};
+use error::{ApiError, ErrorResponse, ERROR_TYPE_UNHANDLED};
 use hyper::{
     client::HttpConnector,
     header::{self, HeaderMap, HeaderValue},
@@ -352,7 +352,7 @@ impl RuntimeClient {
                 header::CONTENT_TYPE,
                 header::HeaderValue::from_static(API_ERROR_CONTENT_TYPE),
             )
-            .header(RUNTIME_ERROR_HEADER, e.error_code)
+            .header(RUNTIME_ERROR_HEADER, HeaderValue::from_static(ERROR_TYPE_UNHANDLED))
             .body(Body::from(body))
             .unwrap()
     }

lambda-runtime-client/src/error.rs

@@ -17,21 +17,21 @@ use serde_json;
 
 /// Error type description for the `ErrorResponse` event. This type should be returned
 /// for errors that were handled by the function code or framework.
-pub const ERROR_TYPE_HANDLED: &str = "Handled";
+#[allow(dead_code)]
+pub(crate) const ERROR_TYPE_HANDLED: &str = "Handled";
 /// Error type description for the `ErrorResponse` event. This type is used for unhandled,
 /// unexpcted errors.
-pub const ERROR_TYPE_UNHANDLED: &str = "Unhandled";
+pub(crate) const ERROR_TYPE_UNHANDLED: &str = "Unhandled";
+/// Error type for the error responses to the Runtime APIs. In the future, this library
+/// should use a customer-generated error code
+pub const RUNTIME_ERROR_TYPE: &str = "RustRuntimeError";
 
 /// This object is used to generate requests to the Lambda Runtime APIs.
 /// It is used for both the error response APIs and fail init calls.
 /// custom error types should implement the `RuntimeError` trait and return
 /// this object to be compatible with the APIs.
 #[derive(Serialize)]
 pub struct ErrorResponse {
-    /// Internal error code to be sent to the Lambda Runtime APIs in the
-    /// `Lambda-Runtime-Function-Error-Type` header.
-    #[serde(skip)]
-    pub error_code: String,
     /// The error message generated by the application.
     #[serde(rename = "errorMessage")]
     pub error_message: String,
@@ -59,11 +59,10 @@ impl ErrorResponse {
     ///
     /// # Return
     /// A new instance of the `ErrorResponse` object.
-    fn new(message: String, err_type: String, code: String) -> ErrorResponse {
+    fn new(message: String, err_type: String) -> ErrorResponse {
         let mut err = ErrorResponse {
             error_message: message,
             error_type: err_type,
-            error_code: code,
             stack_trace: Option::default(),
         };
         let is_backtrace = env::var("RUST_BACKTRACE");
@@ -89,7 +88,7 @@ impl ErrorResponse {
     /// # Return
     /// A populated `RuntimeError` object that can be used with the Lambda Runtime API.
     pub fn handled(message: String) -> ErrorResponse {
-        ErrorResponse::new(message, ERROR_TYPE_HANDLED.to_owned(), "RuntimeError".to_owned())
+        ErrorResponse::new(message, RUNTIME_ERROR_TYPE.to_owned())
     }
 
     /// Creates a new `RuntimeError` object with the unhandled error type.
@@ -101,7 +100,7 @@ impl ErrorResponse {
     /// # Return
     /// A populated `RuntimeError` object that can be used with the Lambda Runtime API.
     pub fn unhandled(message: String) -> ErrorResponse {
-        ErrorResponse::new(message, ERROR_TYPE_UNHANDLED.to_owned(), "RuntimeError".to_owned())
+        ErrorResponse::new(message, RUNTIME_ERROR_TYPE.to_owned())
     }
 }