Skip to content

Commit 7c00720

Browse files
waahm7ianbotsf
andauthored
Fix casing on Windows header files (#730)
Co-authored-by: Ian Botsford <[email protected]>
1 parent 8286c78 commit 7c00720

File tree

10 files changed

+15
-15
lines changed

10 files changed

+15
-15
lines changed

include/aws/io/private/event_loop_impl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ typedef void(aws_event_loop_on_completion_fn)(
2525
size_t num_bytes_transferred);
2626

2727
/**
28-
* The aws_win32_OVERLAPPED struct is layout-compatible with OVERLAPPED as defined in <Windows.h>. It is used
29-
* here to avoid pulling in a dependency on <Windows.h> which would also bring along a lot of bad macros, such
28+
* The aws_win32_OVERLAPPED struct is layout-compatible with OVERLAPPED as defined in <windows.h>. It is used
29+
* here to avoid pulling in a dependency on <windows.h> which would also bring along a lot of bad macros, such
3030
* as redefinitions of GetMessage and GetObject. Note that the OVERLAPPED struct layout in the Windows SDK can
3131
* never be altered without breaking binary compatibility for every existing third-party executable, so there
3232
* is no need to worry about keeping this definition in sync.

include/aws/io/private/pki_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#ifdef _WIN32
1010
/* It's ok to include external headers because this is a PRIVATE header file
1111
* (it is usually a crime to include windows.h from header file) */
12-
# include <Windows.h>
12+
# include <windows.h>
1313
#endif /* _WIN32 */
1414

1515
#ifdef AWS_OS_APPLE

source/windows/host_resolver.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0.
44
*/
55

6-
/* don't move this below the Windows.h include!!!!*/
6+
/* don't move this below the windows.h include!!!!*/
77
#include <winsock2.h>
88
#include <ws2tcpip.h>
99

source/windows/iocp/iocp_event_loop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include <aws/io/logging.h>
1414
#include <aws/io/private/event_loop_impl.h>
1515

16-
#include <Windows.h>
16+
#include <windows.h>
1717

1818
/* The next set of struct definitions are taken directly from the
1919
windows documentation. We can't include the header files directly

source/windows/iocp/pipe.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include <stdbool.h>
1313
#include <stdio.h>
1414

15-
#include <Windows.h>
15+
#include <windows.h>
1616

1717
enum read_end_state {
1818
/* Pipe is open. */

source/windows/iocp/socket.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ keep the bellow includes where they are. Also, sorry about the C++ style comment
99
below, clang-format doesn't work (at least on my version) with the c-style comments.*/
1010

1111
// clang-format off
12-
#include <WS2tcpip.h>
13-
#include <MSWSock.h>
14-
#include <Mstcpip.h>
12+
#include <ws2tcpip.h>
13+
#include <mswsock.h>
14+
#include <mstcpip.h>
1515
// clang-format on
1616

1717
#include <aws/io/private/socket_impl.h>

source/windows/secure_channel_tls_handler.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include <aws/io/private/tls_channel_handler_shared.h>
1919
#include <aws/io/statistics.h>
2020

21-
#include <Windows.h>
21+
#include <windows.h>
2222

2323
#include <schannel.h>
2424
#include <security.h>

source/windows/shared_library.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
// clang-format off
7-
#include <Windows.h>
7+
#include <windows.h>
88
#include <libloaderapi.h>
99
// clang-format on
1010

source/windows/windows_pki_utils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
#include <aws/io/logging.h>
1212

13-
#include <Windows.h>
1413
#include <stdio.h>
1514
#include <string.h>
15+
#include <windows.h>
1616

1717
#ifdef _MSC_VER
1818
# pragma warning(disable : 4221) /* aggregate initializer using local variable addresses */

source/windows/winsock_init.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ go around re-ordering windows header files. Also, sorry about the C++ style comm
88
below, clang-format doesn't work (at least on my version) with the c-style comments. */
99

1010
// clang-format off
11-
#include <WinSock2.h>
12-
#include <WS2tcpip.h>
13-
#include <MSWSock.h>
11+
#include <winsock2.h>
12+
#include <ws2tcpip.h>
13+
#include <mswsock.h>
1414
// clang-format on
1515

1616
#include <aws/io/logging.h>

0 commit comments

Comments
 (0)