Thread join (#305)

* Update to new wait/join api

Author: bretambrose

bin/elasticurl/main.c

@@ -720,11 +720,6 @@ int main(int argc, char **argv) {
     aws_host_resolver_release(resolver);
     aws_event_loop_group_release(el_group);
 
-    if (aws_global_thread_creator_shutdown_wait_for(5)) {
-        fprintf(stderr, "Timeout waiting for thread shutdown!");
-        exit(1);
-    }
-
     if (tls_ctx) {
         aws_tls_connection_options_clean_up(&tls_connection_options);
         aws_tls_ctx_release(tls_ctx);

source/http.c

@@ -464,6 +464,7 @@ void aws_http_library_clean_up(void) {
     }
     s_library_initialized = false;
 
+    aws_thread_join_all_managed();
     aws_unregister_error_info(&s_error_list);
     aws_unregister_log_subject_info_list(&s_log_subject_list);
     s_methods_clean_up();

tests/proxy_test_helper.c

@@ -198,7 +198,6 @@ int proxy_tester_clean_up(struct proxy_tester *tester) {
 
     aws_host_resolver_release(tester->host_resolver);
     aws_event_loop_group_release(tester->event_loop_group);
-    ASSERT_SUCCESS(aws_global_thread_creator_shutdown_wait_for(10));
 
     if (tester->tls_ctx) {
         aws_tls_connection_options_clean_up(&tester->tls_connection_options);

tests/test_connection.c

@@ -327,7 +327,6 @@ static int s_tester_clean_up(struct tester *tester) {
     aws_client_bootstrap_release(tester->client_bootstrap);
     aws_host_resolver_release(tester->host_resolver);
     aws_event_loop_group_release(tester->event_loop_group);
-    ASSERT_SUCCESS(aws_global_thread_creator_shutdown_wait_for(10));
 
     aws_http_library_clean_up();
     aws_logger_clean_up(&tester->logger);

tests/test_connection_manager.c

@@ -371,19 +371,18 @@ static int s_cm_tester_clean_up(void) {
 
     aws_host_resolver_release(tester->host_resolver);
     aws_event_loop_group_release(tester->event_loop_group);
-    ASSERT_SUCCESS(aws_global_thread_creator_shutdown_wait_for(10));
 
     aws_tls_ctx_options_clean_up(&tester->tls_ctx_options);
     aws_tls_connection_options_clean_up(&tester->tls_connection_options);
     aws_tls_ctx_release(tester->tls_ctx);
 
+    aws_http_library_clean_up();
+
     aws_mutex_clean_up(&tester->lock);
     aws_condition_variable_clean_up(&tester->signal);
 
     aws_mutex_clean_up(&tester->mock_time_lock);
 
-    aws_http_library_clean_up();
-
     return AWS_OP_SUCCESS;
 }
 

tests/test_tls.c

@@ -213,8 +213,6 @@ static int s_test_tls_download_medium_file_general(
     aws_host_resolver_release(test.host_resolver);
     aws_event_loop_group_release(test.event_loop_group);
 
-    ASSERT_SUCCESS(aws_global_thread_creator_shutdown_wait_for(10));
-
     aws_tls_ctx_options_clean_up(&tls_ctx_options);
     aws_tls_connection_options_clean_up(&tls_connection_options);
     aws_tls_ctx_release(test.tls_ctx);