Suppress compiler warning C4232 (function pointer to dll symbol) for MSVC. (#266)

Author: wps132230

include/aws/http/private/h2_frames.h

@@ -64,7 +64,9 @@ AWS_HTTP_API
 extern const uint32_t aws_h2_settings_initial[AWS_HTTP2_SETTINGS_END_RANGE];
 
 /* This magic string must be the very first thing a client sends to the server.
- * See RFC-7540 3.5 - HTTP/2 Connection Preface */
+ * See RFC-7540 3.5 - HTTP/2 Connection Preface.
+ * Exported for tests */
+AWS_HTTP_API
 extern const struct aws_byte_cursor aws_h2_connection_preface_client_string;
 
 /**

source/connection.c

@@ -22,6 +22,7 @@
 
 #if _MSC_VER
 #    pragma warning(disable : 4204) /* non-constant aggregate initializer */
+#    pragma warning(disable : 4232) /* function pointer to dll symbol */
 #endif
 
 static struct aws_http_connection_system_vtable s_default_system_vtable = {

source/connection_manager.c

@@ -23,6 +23,10 @@
 #include <aws/common/mutex.h>
 #include <aws/common/string.h>
 
+#if _MSC_VER
+#    pragma warning(disable : 4232) /* function pointer to dll symbol */
+#endif
+
 /*
  * Established connections not currently in use are tracked via this structure.
  */

source/h2_frames.c

@@ -23,8 +23,7 @@
 
 #define ENCODER_LOG(level, encoder, text) ENCODER_LOGF(level, encoder, "%s", text)
 
-/* exported for tests */
-AWS_HTTP_API const struct aws_byte_cursor aws_h2_connection_preface_client_string =
+const struct aws_byte_cursor aws_h2_connection_preface_client_string =
     AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n");
 
 /* Initial values and bounds are from RFC-7540 6.5.2 */

source/proxy_connection.c

@@ -16,6 +16,7 @@
 
 #if _MSC_VER
 #    pragma warning(disable : 4204) /* non-constant aggregate initializer */
+#    pragma warning(disable : 4232) /* function pointer to dll symbol */
 #endif
 
 AWS_STATIC_STRING_FROM_LITERAL(s_host_header_name, "Host");