Skip to content

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 22, 2025

Motivation and Context

Remove the echo command as the last command in the build step so that
CodeBuild uses the exit status of mvn as the result of the job.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the dongie/fix-buildspec branch from ae45380 to 7c629b6 Compare October 22, 2025 23:31
Remove the echo command as the last command in the build step so that
CodeBuild uses the exit status of mvn as the result of the job.
@dagnir dagnir force-pushed the dongie/fix-buildspec branch from 49057f6 to 26da0ba Compare November 7, 2025 22:53
@dagnir dagnir changed the title [WIP] Remove echo command Remove echo command Nov 7, 2025
@dagnir dagnir marked this pull request as ready for review November 7, 2025 22:54
@dagnir dagnir requested a review from a team as a code owner November 7, 2025 22:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@dagnir dagnir added this pull request to the merge queue Nov 10, 2025
@dagnir dagnir mentioned this pull request Nov 10, 2025
12 tasks
Merged via the queue into master with commit 1bdb9cd Nov 10, 2025
37 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants